Fix dict representation not being JSON serializable #1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkLight1337
force-pushed
the
fix-dict-json-serialize
branch
from
9a65b9d to
0b95088
Compare
DarkLight1337
changed the title
|
Looks like we might need to lock the NumPy version to avoid binary incompatibility with SciPy. |
|
You mean this cryptic message on windows only?
I don't know where the scipy dependency is coming from, but we could remove it in the windows run. |
Yeah. |
|
OK, things magically fixed themselves :). Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
AbstractFileSystem.to_dict()failing to serialize recursive filesystem/paths which caused the output to not be JSON serializable.