Disable more ruff rules #1610
Disable more ruff rules #1610
Conversation
They are not compatible with `ruff format` or are actual anti-patterns.
|
@Skylion007 , thoughts ? |
| @@ -189,6 +189,23 @@ ignore = [ | |||
| # Fix these codes later | |||
| "G004", | |||
| "PERF203", | |||
| # https://github.com/astral-sh/ruff/issues/7871 | |||
| "UP038", | |||
There was a problem hiding this comment.
This should be disabled, but it should also be tabled by setting the target python version low enough.
There was a problem hiding this comment.
Could you provide more precise guidance? Right now, the minimal supported version is defined in pyproject.toml:
requires-python = ">=3.8"What would you like to change? Also, why should the minimal supported version of Python depend on a ruff rule?
There was a problem hiding this comment.
@Skylion007 , are you OK with having "UP038" in this list for now?
There was a problem hiding this comment.
Leave it disabled, it doesn't affect us anyway.
If it's really triggering despite the Python version, this might be a ruff a bug that we should file upstream though. It's suppose to have version checks to prevent it suggesting upgrades which break the min version.
They are not compatible with
ruff formator are actual anti-patterns.