Skip to content

Fix ruff 0.4.4 issue #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@martindurant
Copy link
Member

Linter now complains

fsspec/implementations/tests/test_dirfs.py:358:9: PERF402 Use `list` or `list.copy` to create a copy of a list
fsspec/implementations/tests/test_http.py:569:9: PERF402 Use `list` or `list.copy` to create a copy of a list

@DimitriPapadopoulos

This comment was marked as outdated.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented May 22, 2024

It's actually pre-commit:

▶ Run pre-commit run --show-diff-on-failure --color=always --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check docstring is first.................................................Passed
check json...........................................(no files to check)Skipped
check yaml...............................................................Passed
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

I can fix the version of ruff used by pre-commit.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft May 22, 2024 14:32
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PERF401 branch 3 times, most recently from e7e1461 to d529735 Compare May 22, 2024 14:51
These warnings appears to raised by ruff 0.4.4, not 0.3.4:

PERF401 Use an async list comprehension to create a transformed list
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review May 22, 2024 15:08
@DimitriPapadopoulos DimitriPapadopoulos changed the title Fix ruff 0.4.4 issues Fix ruff 0.4.4 issue May 22, 2024
@martindurant martindurant merged commit 7b604b8 into fsspec:master May 24, 2024
11 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PERF401 branch May 24, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants