make route for become-a-provider #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make EmailProviderRequest's Cancel be a link to /
shannonwells
force-pushed
the
feat/link-become-provider-#183
branch
from
3a6c311 to
c191272
Compare
shannonwells
commented
Oct 31, 2024
| import ProviderLogin from '$components/ProviderLogin.svelte'; | ||
| import { pageContent, PageContent } from '$lib/stores/pageContentStore'; | ||
| </script> | ||
|
|
||
| {#if $pageContent === PageContent.Dashboard} | ||
| <Dashboard /> | ||
| {:else if $pageContent === PageContent.Login} | ||
| {:else} | ||
| <ProviderLogin /> |
There was a problem hiding this comment.
Since it's just a link now we don't need 3 conditions.
shannonwells
commented
Oct 31, 2024
| @@ -8,28 +8,20 @@ import userEvent from '@testing-library/user-event'; | |||
| globalThis.alert = () => {}; | |||
|
|
|||
| describe('CreateProvider component', () => { | |||
| const mockCancelAction = vi.fn(); | |||
There was a problem hiding this comment.
cancelActionsand mockCancelActions all were canceled went away because now you just go back to root, as a link.
- webkit and firefox passing now for some reason - add clicking the 'Home' button to the playwright navigation test
JoeCap08055
requested changes
Nov 1, 2024
JoeCap08055
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to make a route for become-a-provider so that it's easier to navigate between the login/become provider routes and so that clicking Home takes you to the website root, i.e. main page.
I also added Playwright to test navigation and for future tests, however, I didn't add it to CI since it was starting to get further out of scope. There is a chore for it now though: #191
Closes #183
Checklist
How To Test the Changes
After verifying that the Playwright tests passed:
a. the browser back button takes you back home.
b. the 'Back' link takes you back home.
c. ... and selecting Testnet network, the 'Cancel' link takes you back home.
d. ... and selecting Mainnet network, the 'Cancel' link takes you back home.
/become-a-providerafter the root and it shows you the Become A Provider page, and that the buttons all do what they're supposed to.