ethereum utility library #2404
ethereum utility library #2404
Conversation
| verifyingContract: '0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC', | ||
| }; | ||
|
|
||
| export const ADD_PROVIDER_DEFINITION = { |
There was a problem hiding this comment.
Again, I don't think so, but I wonder if we need to version these in any way? I guess we can later add _V2 on the end without issue.
There was a problem hiding this comment.
I would say, any structs that already are at "V2" should get _V2 appended to the const name now.
There was a problem hiding this comment.
If it the only version based on our existing convention I didn't add any version but all versions > 1 should have the version in the name unless there's been a mistake (just like what Joe suggested)
| @@ -97,50 +97,6 @@ export function signPayload(keys: KeyringPair, data: Codec): MultiSignatureType | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
aramikm
requested review from
shannonwells,
mattheworris,
enddynayn and
JoeCap08055
| @@ -0,0 +1 @@ | |||
| nodejs 20.12.2 | |||
There was a problem hiding this comment.
nit: e2e tests are using 22.12.0.
There was a problem hiding this comment.
correct, but I think since we have other clients that are using node 20 it made sense to use the older version since this is going to be a dependency for those.
Goal
The goal of this PR is to create a ethereum utility library which can help us dealing with ethereum addresses and signatures and etc.
Closes #2281
What is added?
Checklist