Subsidize adding an Ethereum compatible control key #2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
commented
May 13, 2025
| @@ -46,5 +46,8 @@ | |||
| "tsx": "^4.19.3", | |||
| "typescript": "^5.8.3", | |||
| "typescript-eslint": "^8.30.1" | |||
| }, | |||
| "optionalDependencies": { | |||
There was a problem hiding this comment.
Needed for running e2e tests locally on Ubuntu
github-actions
bot
added
metadata-changed
shannonwells
commented
May 13, 2025
github-actions
bot
added
the
metadata-changed
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
shannonwells
requested review from
a team,
mattheworris,
enddynayn,
aramikm,
claireclark1 and
JoeCap08055
and removed request for
a team
JoeCap08055
reviewed
May 13, 2025
JoeCap08055
reviewed
May 13, 2025
JoeCap08055
reviewed
May 13, 2025
JoeCap08055
reviewed
May 13, 2025
shannonwells
force-pushed
the
feat/free-add_key-#2286
branch
from
ca3b553 to
844f53e
Compare
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
JoeCap08055
reviewed
May 21, 2025
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
the
metadata-changed
shannonwells
changed the title
shannonwells
commented
May 21, 2025
aramikm
reviewed
May 22, 2025
pallets/msa/src/weights.rs
Outdated
There was a problem hiding this comment.
if no additional functions are added or removed then maybe this should not get committed!?
There was a problem hiding this comment.
oversight, thanks
mattheworris
approved these changes
May 22, 2025
bug fixed, tests passing
Update e2e/scaffolding/helpers.ts remove backticks Co-authored-by: Joe Caputo <[email protected]>
…gibility * Pay for 2nd key w/ capacity if ethereum is a low cost transaction. * e2e tests for same.
* Rename eligibility function * extract rust tests to own file
shannonwells
force-pushed
the
feat/free-add_key-#2286
branch
from
2d60894 to
0ff2ee2
Compare
github-actions
bot
added
metadata-changed
aramikm
approved these changes
May 23, 2025
JoeCap08055
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to allow adding a second key to be a
freesubsidized capacity transaction under specific circumstances. This change reduces the capacity fee by about 70% when there is one key, and the new key is Ethereum-compatible.Most of #2286
Discussion
Note on something easy to miss: the expiration block will default to 0, which means this feature is off by default, until the value is set to a block in the future. There is no on-chain monitoring of the usage of this feature.
Checklist
freesubsidized key addition period.not applicable
- [ ] Design doc(s) updated?