Skip to content

Updates to Provider Boosting Design Docs #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 19, 2024
Merged

Updates to Provider Boosting Design Docs #1940

merged 27 commits into from
Apr 19, 2024

Conversation

shannonwells
Copy link
Collaborator

@shannonwells shannonwells commented Apr 17, 2024 •
edited
Loading

Goal

The goal of this PR is to add the updates to the Provider Boost Economic Model Design Doc based on the recent economic model decisions by @harry-evans

Closes #1318

Discussion

  • The implementation and the economic model have been split into two Design Docs.
  • Rebased against the implementation Design Doc changes in main and then renamed the file.

Checklist

  • Design doc(s) updated

@shannonwells
some words
b9dcf89
@shannonwells
outline some code requirements, reason about when to calculate and as…
8ee145f 
…sign staking rewards
@shannonwells
outline some more ideas, example code, example rewards formulas
559e55b
@shannonwells
unstaking and staking spam
2561d97
@shannonwells
allow rewards to be claimed via extrinsic
82dbad0
@shannonwells
remove bad argument
7b34382
@shannonwells
remove irrelevant non-choices
885ec73
@shannonwells
thoughts
4461807
@shannonwells
changed my mind
5efb053
@shannonwells
Update capacity_staking_rewards.md
bff052a 
Some corrections
@shannonwells
Formatting, eqns
8fe7169
@shannonwells
Corrected eqns
5ef6216
@shannonwells
Update capacity_staking_rewards.md
f5ec192
@shannonwells
Update capacity_staking_rewards.md
66dbd5f 
simple ratio just don't work
@shannonwells
WIP
3ec3939
@shannonwells
updates to design docs to use a capacity rewards interface
e768cd4
@shannonwells
updates reflecting economic model (WIP)
0e88e75
@shannonwells
rename
a1ef541
@shannonwells
econ model updates pt 2
e731a7c
@shannonwells
Merge branch 'main' into feat/capacity-staking-rewards-designdoc
1e1b37f
@shannonwells
Update provider_boosting_economic_model.md
78b917c
@shannonwells
some clarifications in the equations
f173d36
wilwade
wilwade reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few notes on claiming, but everything else aligns with my understanding of the discussions.

wilwade
wilwade approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct as it can be to me currently.

  • ✅ Reviewed

enddynayn
enddynayn reviewed Apr 17, 2024
View reviewed changes
enddynayn
enddynayn reviewed Apr 17, 2024
View reviewed changes
enddynayn
enddynayn reviewed Apr 17, 2024
View reviewed changes
@shannonwells shannonwells marked this pull request as ready for review April 17, 2024 17:16
@shannonwells shannonwells changed the title [WIP] Updates to Provider Boosting Design Docs Updates to Provider Boosting Design Docs Apr 17, 2024
@shannonwells shannonwells requested a review from enddynayn April 17, 2024 23:56
@shannonwells shannonwells enabled auto-merge (squash) April 17, 2024 23:56
enddynayn
enddynayn approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 exciting!

saraswatpuneet
saraswatpuneet reviewed Apr 19, 2024
View reviewed changes
designdocs/provider_boosting_economic_model.md

## Claiming Rewards
* Provider Boost Rewards are not minted until they are explicitly <i>claimed</i> by the Provider Boost account holder, by calling a non-free extrinsic.
* Rewards must be claimed within a certain number of Provider Boost Eras.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if claimant account did not claim within required numbers of eras?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shannonwells will know for sure, but I believe the oldest rewards are pushed off the stack.

saraswatpuneet
saraswatpuneet approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice overview, left one question but not a blocker

@shannonwells shannonwells merged commit 8dfa47d into main Apr 19, 2024
29 checks passed
@shannonwells shannonwells deleted the feat/capacity-staking-rewards-designdoc branch April 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwade wilwade wilwade approved these changes

@enddynayn enddynayn enddynayn approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

Assignees
No one assigned
Labels
Provider Boosting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Staking Rewards] Economic model design doc
4 participants
@shannonwells @wilwade @enddynayn @saraswatpuneet