This repository was archived by the owner on Oct 21, 2020. It is now read-only.
refactor(unit tests): DRY up the unit tests for invalid community events #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need f32d0b7 to go green |
|
@ojongerius close/open PR to update config in Travis CI |
|
@ojongerius It doesn't matter |
|
@ValeraS I'm not sure what you mean, could please elaborate? |
|
|
|
@ojongerius If close/open PR Travis CI will start a new build and take for this build config from the master branch. Restart build in Travis CI UI does not update config. |
|
@ValeraS aha! Nice trick 👍 |
|
@ojongerius After updating the configuration or if the cofig is up to date, you can simply restart the build in Travis itself, if you need to. No need to close/open PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #188. We're looking for feedback on this refactor to DRY up the unit tests. Please let us know if we are going in the right direction. Thank you.