Add functionality to use check-in app for QR code scanning with eventyay #115

Sak1012 · 2024-06-26T19:27:06Z

This pull request contains the initial commit addressing Issue #190 (Integrate Badges Plugin with Check-in App for QR Code Scanning) in the eventyay-tickets repository.

Overview:
In this PR, a "Register Device" button has been added to the home page. This button redirects organizers to a QR code scan interface, allowing them to register their devices similarly to the functionality of pretix-scan.

Screenshots:

Home page with "Register Device" button:
QR Code Scan Interface:

QR Code Data Format:
The "Connect to Device" QR code in eventyay-tickets provides JSON data in the following format:

{
    "handshake_version": 1, 
    "url": "http://localhost", 
    "token": "cgakvwle23d2qxwa"
}

Progress Checklist

Add the required frontend button and route to scan QR code to register a device.
Implement logic to scan, validate, and connect to the device using the QR code from eventyay-tickets.
Add functions to retrieve event details.
Redirect to panel/select-station once the device is connected.
Configure support for tickets from eventyay-tickets.
Display a preview of the badge once the attendee is checked in.

This feature enhances the integration between the badges plugin and the check-in app, allowing event organizers to seamlessly register and manage devices using QR codes. The implementation is inspired by the functionality of pretix-scan.

Summary by Sourcery

This pull request introduces a new feature allowing event organizers to register devices via a QR code scan interface. A 'Register Device' button has been added to the home page, leading to a new route and component for device registration. Additionally, the login form has been enhanced with a server selection dropdown and corresponding error handling.

New Features:
- Added a 'Register Device' button to the home page, which redirects to a QR code scan interface for device registration.
- Implemented a new route and component for device registration using QR codes.
- Introduced a new store for handling device registration logic and API interactions.
Enhancements:
- Updated the login form to include a server selection dropdown and error handling for server selection.

netlify · 2024-06-26T19:27:20Z

✅ Deploy Preview for open-event-checkin ready!

Name	Link
🔨 Latest commit	`d2ff327`
🔍 Latest deploy log	https://app.netlify.com/sites/open-event-checkin/deploys/67319081ac830c00088838a9
😎 Deploy Preview	https://deploy-preview-115--open-event-checkin.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mariobehling · 2024-06-27T08:38:53Z

Thank you. You can show the functionality in the weekly meetings and we can discuss then if we should keep this in a seperate branch.

Sak1012 · 2024-07-02T04:42:13Z

I have added the required frontend component to select a server in the LoginForm Component

Screen Shots

Sak1012 · 2024-07-20T02:03:21Z

A "/eventyayevents" page has been added from where the events can be selected to perform checkin actions from a list of events the device has access to.

This PR has multiple console.log() for testing purpose and will be removed in later commits.

mariobehling · 2024-07-22T06:31:46Z

@sourcery-ai review

sourcery-ai · 2024-07-22T06:32:15Z

Reviewer's Guide by Sourcery

This pull request introduces a new feature allowing event organizers to register devices via a QR code scan interface. A 'Register Device' button has been added to the home page, and new routes and components have been implemented to support this functionality. Additionally, the login form has been enhanced with a server selection dropdown and corresponding error handling.

File-Level Changes

Files	Changes
`src/components/LoginForm.vue` `src/router/index.js` `src/components/Common/QRCamera.vue` `src/stores/processDevice.js` `src/components/Eventyay/EventyayEvents.vue` `src/stores/eventyayEvent.js` `src/components/Registration/Device/Device.vue`	Introduced a new feature for device registration via QR code scanning, including UI components, routes, and state management.

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
Continue your discussion with Sourcery by replying directly to review comments.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

sourcery-ai

Hey @Sak1012 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

Define submitForm method (link)

Here's what I looked at during the review

🔴 General issues: 1 blocking issue, 9 other issues
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

src/components/LoginForm.vue

sourcery-ai · 2024-07-22T06:33:12Z

src/components/LoginForm.vue


 // router
 const router = useRouter()

 async function submitLogin() {
+  console.log(server.value)
+  if (server.value === '' || server.value === 'Select a Server') {


suggestion: Consider using a constant for the default server value

Using a constant for the default server value ('Select a Server') can help avoid potential typos and make the code easier to maintain.

Suggested change

if (server.value === '' || server.value === 'Select a Server') {

const DEFAULT_SERVER_VALUE = 'Select a Server';

if (server.value === '' || server.value === DEFAULT_SERVER_VALUE) {

src/components/LoginForm.vue

src/stores/processDevice.js

sourcery-ai · 2024-07-22T06:33:13Z

src/stores/eventyayEvent.js

+
+    try {
+      const api = mande(url, { headers: { Authorization: `Device ${apiToken}` } })
+      console.log(`/api/v1/organizers/${organizer}/events/`)


issue (performance): Remove console.log statements

Leaving console.log statements in production code can lead to performance issues and potential information leakage. Consider removing or replacing them with proper logging mechanisms.

sourcery-ai · 2024-07-22T06:33:13Z

src/stores/eventyayEvent.js

+      const api = mande(url, { headers: { Authorization: `Device ${apiToken}` } })
+      console.log(`/api/v1/organizers/${organizer}/events/`)
+      const response = await api.get(`/api/v1/organizers/${organizer}/events/`)
+      console.log('Hello', response)


issue (performance): Remove console.log statements

Leaving console.log statements in production code can lead to performance issues and potential information leakage. Consider removing or replacing them with proper logging mechanisms.

src/components/Eventyay/EventyayEvents.vue

sourcery-ai · 2024-07-22T06:33:13Z

src/components/Eventyay/EventyayEvents.vue

+        />
+      </div>
+    </form>
+    <div v-if="!loading && !events.length && !error">No events available</div>


suggestion: Consider adding a retry mechanism

If no events are available, consider providing a retry mechanism or a more detailed message to guide the user.

Suggested change

<div v-if="!loading && !events.length && !error">No events available</div>

<div v-if="!loading && !events.length && !error">

No events available

<button @click="fetchEvents">Retry</button>

</div>

mariobehling · 2024-07-24T10:27:04Z

@sourcery-ai review

sourcery-ai

Hey @Sak1012 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

Potential hard-coded secret found in 'token' field. (link)
Potential hard-coded secret found. (link)

Overall Comments:

The error handling in the authDevice function could be improved. Consider using more specific error types and providing more informative error messages to the user.
The hardcoded port number for localhost (:8000) in the authDevice function is not a good practice. Consider making this configurable or using a default port that doesn't require modification.
There's no input validation for the manual device key entry in the Device.vue component. Implement proper validation to ensure the entered key meets the required format and length.

Here's what I looked at during the review

🟡 General issues: 10 issues found
🔴 Security: 2 blocking issues
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

sourcery-ai · 2024-07-24T10:28:38Z

src/components/LoginForm.vue


 // router
 const router = useRouter()

 async function submitLogin() {
+  console.log(server.value)


suggestion: Remove console.log statements

Consider removing the console.log statements used for debugging purposes before merging the code to the main branch.

Suggested change

console.log(server.value)

const router = useRouter()

async function submitLogin() {

if (server.value === '' || server.value === 'Select a Server') {

showServerError.value = true

sourcery-ai · 2024-07-24T10:28:39Z

src/components/LoginForm.vue


 // router
 const router = useRouter()

 async function submitLogin() {
+  console.log(server.value)
+  if (server.value === '' || server.value === 'Select a Server') {


suggestion: Use a constant for 'Select a Server'

Consider defining 'Select a Server' as a constant to avoid potential typos and make the code more maintainable.

Suggested change

if (server.value === '' || server.value === 'Select a Server') {

const SELECT_A_SERVER = 'Select a Server';

if (server.value === '' || server.value === SELECT_A_SERVER) {

Please define constants to compare server.value with.

Absolutely, defining constants for strings like 'Select a Server' is a great practice. It helps prevent typos and makes the code more readable and maintainable. You can define the constant at the top of your script or in a separate configuration file if it's used across multiple components. Here's how you can implement it:

const SELECT_A_SERVER = 'Select a Server'; if (server.value === '' || server.value === SELECT_A_SERVER) { // Handle the error case }

This way, if you ever need to change the placeholder text, you only have to update it in one place. Let me know if you need further assistance!

Done, I have fixed it in the recent commit.

Great to hear that you've implemented the change! Using constants for strings is definitely a good practice for maintaining clean and error-free code. If you have any more questions or need further assistance with anything else in the PR, feel free to ask. Keep up the good work!

sourcery-ai · 2024-07-24T10:28:39Z

src/components/LoginForm.vue

+      <StandardButton
+        :type="'button'"
+        :text="'Register-Device'"
+        :disabled="false"
+        class="btn-primary mt-6 w-full justify-center"
+        @click="registerDevice"
+      >
+      </StandardButton>


suggestion: Button text should be a prop

Consider passing the button text as a prop to the StandardButton component for better reusability and consistency.

Suggested change

<StandardButton

:type="'button'"

:text="'Register-Device'"

:disabled="false"

class="btn-primary mt-6 w-full justify-center"

@click="registerDevice"

>

</StandardButton>

<StandardButton

:type="'button'"

:text="buttonText"

:disabled="false"

class="btn-primary mt-6 w-full justify-center"

@click="registerDevice"

/>

If you are passing a static string (Register-Device) to text prop, no point to use bind syntax and JS expression.

Just pass as normal HTML attribute like this:

<StandardButton text='Register-Device' ... />

Great point, @hongquan! If the button text is static and won't change, using a regular HTML attribute is indeed more straightforward and cleaner. However, if there's a possibility that the button text might need to be dynamic or localized in the future, passing it as a prop could be beneficial for flexibility. It really depends on the expected use case. If you foresee any changes or need for localization, consider using a prop; otherwise, your suggestion is perfectly valid for a static text.

As this was the convention followed everywhere else where StandardButton component was previously being used, I too did the same should I still change it ?

If the convention in your codebase is to use the binding syntax for the text prop, even for static strings, it's generally a good idea to maintain consistency with the existing code. This can help with readability and maintainability, especially if there's a chance that the text might become dynamic or require localization in the future.

However, if you and your team decide that using a regular HTML attribute for static text is more appropriate and aligns with your coding standards, you can certainly make that change. Consistency is key, so whichever approach you choose, it would be beneficial to apply it uniformly across your project.

If you're unsure, it might be worth discussing with your team to see if there's a preference or if there's a plan to make the button text dynamic in the future.

That is not convention, previous people simply don't understand VueJS well enough.

It sounds like there's a bit of a misunderstanding about the use of VueJS syntax in your codebase. If the current practice is to use the binding syntax for static strings, it might be due to a lack of understanding rather than a deliberate convention.

Given this, it could be a good opportunity to align on best practices with your team. Using a regular HTML attribute for static text is more straightforward and should be preferred unless there's a specific reason to use the binding syntax, such as future plans for dynamic content or localization.

If you decide to switch to using regular HTML attributes for static text, it might be helpful to update the existing code for consistency. This could also be a chance to document this as a coding standard for your team to follow moving forward. If you need further guidance, consider discussing this with your team or a lead developer to ensure everyone is on the same page.

This is how the button is defined

<script setup> const props = defineProps({ type: { type: String, default: 'button' }, text: { type: String, default: '' }, disabled: { type: Boolean, default: false }, icon: { type: Function, default: () => null }, iconAfter: { type: Function, default: () => null } }) </script> <template> <button :type="type" :disabled="disabled" class="inline-flex items-center"> <component :is="icon" v-if="icon" :class="[text !== '' ? 'mr-1 h-5' : 'h-5']" /> <span>{{ text }}</span> <component :is="iconAfter" v-if="iconAfter" :class="[text !== '' ? 'ml-1 h-5' : 'h-5']" /> </button> </template>

Hence I'm passing it as a prop

I know that it is a prop, see my previous comment:

If you are passing a static string (Register-Device) to text prop

Being a "prop", it doesn't mean that you always have to use Vue syntax when passing a value to it.

sourcery-ai · 2024-07-24T10:28:39Z

src/components/LoginForm.vue

+      <div v-if="showServerError" class="mt-5">
+        <p class="text-center text-sm text-danger">Please select a server first</p>


suggestion: Error message should be configurable

Consider making the error message configurable or translatable to support multiple languages.

Suggested change

<div v-if="showServerError" class="mt-5">

<p class="text-center text-sm text-danger">Please select a server first</p>

<div v-if="showServerError" class="mt-5">

<p class="text-center text-sm text-danger">{{ errorMessage }}</p>

src/router/index.js

sourcery-ai · 2024-07-24T10:28:39Z

src/stores/processDevice.js

+      if (url.includes('localhost')) {
+        url = `${url}:8000` // Add your desired port number here


suggestion: Avoid hardcoding port number

Consider making the port number configurable instead of hardcoding it.

Suggested change

if (url.includes('localhost')) {

url = `${url}:8000` // Add your desired port number here

const port = process.env.PORT || 8000;

if (url.includes('localhost')) {

url = `${url}:${port}`

Please do as sourcery-ai suggested.

Absolutely, making the port number configurable is a good practice as it enhances flexibility and adaptability across different environments. By using process.env.PORT || 8000, you allow the application to dynamically adapt to the port specified in the environment variables, while still providing a default value of 8000 if none is set. This approach is particularly useful in development and deployment scenarios where the port might vary. If you need any help implementing this change or have further questions, feel free to ask!

I have fixed this in the recent commit.

Great to hear that you've implemented the change, @Sak1012! Making the port configurable is a solid improvement. If you encounter any issues or have further questions as you continue working on this feature, feel free to reach out. Keep up the good work!

src/components/Eventyay/EventyayEvents.vue

sourcery-ai · 2024-07-24T10:28:39Z

src/stores/eventyayEvent.js

+
+    try {
+      const api = mande(url, { headers: { Authorization: `Device ${apiToken}` } })
+      console.log(`/api/v1/organizers/${organizer}/events/`)


suggestion: Remove console.log statements

Consider removing the console.log statements used for debugging purposes before merging the code to the main branch.

Suggested change

console.log(`/api/v1/organizers/${organizer}/events/`)

// console.log(`/api/v1/organizers/${organizer}/events/`)

src/stores/processDevice.js

hs

hongquan · 2024-08-18T07:49:37Z

src/components/LoginForm.vue


 // router
 const router = useRouter()

 async function submitLogin() {
+  console.log(server.value)
+  if (server.value === '' || server.value === 'Select a Server') {


Please define constants to compare server.value with.

hongquan · 2024-08-18T07:52:59Z

src/components/LoginForm.vue

+      <StandardButton
+        :type="'button'"
+        :text="'Register-Device'"
+        :disabled="false"
+        class="btn-primary mt-6 w-full justify-center"
+        @click="registerDevice"
+      >
+      </StandardButton>


If you are passing a static string (Register-Device) to text prop, no point to use bind syntax and JS expression.

Just pass as normal HTML attribute like this:

<StandardButton text='Register-Device' ... />

src/router/index.js

hongquan · 2024-08-18T07:58:54Z

src/stores/processDevice.js

+      if (url.includes('localhost')) {
+        url = `${url}:8000` // Add your desired port number here


Please do as sourcery-ai suggested.

This also has minor fixes and removal of some `console.log()` statements and added env variable for local host testing

hongquan · 2024-08-19T11:20:20Z

In this PR, every where you pass static string to Vue component, please use normal HTML instead of :prop syntax.

Sak1012 · 2024-10-14T15:03:54Z

This PR covers most of the functionalities required to integrate the Eventyay component with Open Event Checkin. I’ve also resolved the requested changes. Kindly review this.

Sak1012 · 2024-10-18T09:38:33Z

In the latest commit i'm integrating Lead API and Checkin API in open-event-checkin, The Lead API is working completely fine but i'm still facing issues with the checkin api as it is not responding to the device token.

src/components/Eventyay/LeadScanning.vue

src/components/LoginForm.vue

Major Changes Done to the Workflow and the tokens stored Local Storage is now moves to eventyayapi store

.env

Added Feature to include notes and tags on scanned Lead Added Option to export lead data as CSV Made some changes to handling Checkin

Sak1012 · 2024-10-29T04:14:17Z

Added option to export scanned leads as csv

ID,Pseudonymization ID,Scanned Date,Scan Type,Device Name,Attendee Name,Email,Note,Tags
35,GYPZHJDQGV,2024-10-29,lead,Test,Jane Doe,,Meet on Friday,Anonymus; USA
36,ML7ZRUARDG,2024-10-29,lead,Test,Srivatsav,,,Photographer; USA
37,JPW8BQTCRR,2024-10-29,lead,Test,Charles Xavier,,,X-men;

ID	Pseudonymization ID	Scanned Date	Scan Type	Device Name	Attendee Name	Note	Tags
35	GYPZHJDQGV	2024-10-29	lead	Test	Jane Doe	Meet on Friday	Anonymus; USA
36	ML7ZRUARDG	2024-10-29	lead	Test	Srivatsav		India
37	JPW8BQTCRR	2024-10-29	lead	Test	Charles Xavier		X-men

Sak1012 · 2024-10-31T12:17:50Z

src/components/Eventyay/EventyayEvents.vue

@@ -23,9 +23,11 @@ const submitForm = () => {
  if (selectedEvent.value) {
    const selectedEventData = events.find((event) => event.slug === selectedEvent.value)
    if (selectedEventData) {
+      console.log('Selected Event:', selectedEventData)
+      console.log('Selected Role:', selectedRole)


This will be removed

Add Device Registration button and route

0771e62

Added Select Server option in LoginForm

077215b

Added basic QR handling logic

4c8f4da

sourcery-ai bot reviewed Jul 22, 2024

View reviewed changes

Device auth and event list selection

57f721b

Sak1012 force-pushed the badge-integration branch from 6834ad7 to 57f721b Compare July 22, 2024 10:58

Added Field to enter Device Auth Token manually

cbc8b39

sourcery-ai bot reviewed Jul 24, 2024

View reviewed changes

Added Ticket QR scanning Page

3405c89

Sak1012 force-pushed the badge-integration branch from 3988864 to 998dc45 Compare August 6, 2024 03:57

Fixes

4f382e0

Sak1012 force-pushed the badge-integration branch from 998dc45 to 4f382e0 Compare August 6, 2024 03:58

mariobehling requested a review from hongquan August 17, 2024 15:36

hongquan requested changes Aug 18, 2024

View reviewed changes

Add Eventyay route Selection Page

67ee3dd

This also has minor fixes and removal of some `console.log()` statements and added env variable for local host testing

Added basic auth logic for leed scanning

b505113

Sak1012 force-pushed the badge-integration branch from ed47b8c to b505113 Compare September 9, 2024 10:55

Sak1012 changed the title ~~Add Device Registration button and route~~ Eventyay-tickets Integration Sep 9, 2024

Sak1012 requested a review from hongquan October 14, 2024 15:04

Add Lead API and Check-in API

67e1679

Sak1012 force-pushed the badge-integration branch from 88baa07 to 67e1679 Compare October 18, 2024 09:57

hongquan requested changes Oct 18, 2024

View reviewed changes

src/components/Eventyay/LeadScanning.vue Outdated Show resolved Hide resolved

src/components/LoginForm.vue Outdated Show resolved Hide resolved

Fix Syntax

e168a42

Sak1012 force-pushed the badge-integration branch from c4b3e88 to e168a42 Compare October 18, 2024 11:02

Changed The Workflow

d016d4c

Major Changes Done to the Workflow and the tokens stored Local Storage is now moves to eventyayapi store

mariobehling requested changes Oct 20, 2024

View reviewed changes

.env Outdated Show resolved Hide resolved

Added Popup to show scanned lead info

049a99e

Sak1012 force-pushed the badge-integration branch from 66562d1 to 049a99e Compare October 22, 2024 17:17

Sak1012 added 2 commits October 22, 2024 22:49

Update .env

da28507

Added additional Lead Fucntionality

e188f12

Added Feature to include notes and tags on scanned Lead Added Option to export lead data as CSV Made some changes to handling Checkin

Sak1012 added 3 commits October 30, 2024 19:41

Changes

426cf90

Updated Lead Scanning and CSV to now support Booth Info

fa04c51

Add logout functionality to maintain session

1e76141

Sak1012 commented Oct 31, 2024

View reviewed changes

mariobehling changed the title ~~Eventyay-tickets Integration~~ Add functionality to use check-in app for QR code scanning with eventyay Nov 1, 2024

Sak1012 added 5 commits November 4, 2024 01:03

Add Badge preview and printing option and modify Event Selection Page

42f2a92

Env Variable fix

91a9325

Workflow fix

c95c222

conf fix

f3e6f71

Add Search and Checkin

d2ff327

-  if (server.value === '' || server.value === 'Select a Server') {
+const DEFAULT_SERVER_VALUE = 'Select a Server';
+if (server.value === '' || server.value === DEFAULT_SERVER_VALUE) {

-  if (server.value === '' || server.value === 'Select a Server') {
+const SELECT_A_SERVER = 'Select a Server';
+if (server.value === '' || server.value === SELECT_A_SERVER) {

		<div v-if="showServerError" class="mt-5">
		<p class="text-center text-sm text-danger">Please select a server first</p>

		if (url.includes('localhost')) {
		url = `${url}:8000` // Add your desired port number here

	console.log(`/api/v1/organizers/${organizer}/events/`)
	// console.log(`/api/v1/organizers/${organizer}/events/`)

Add functionality to use check-in app for QR code scanning with eventyay #115

Are you sure you want to change the base?

Add functionality to use check-in app for QR code scanning with eventyay #115

Conversation

Sak1012 commented Jun 26, 2024 • edited Loading

Summary by Sourcery

netlify bot commented Jun 26, 2024 • edited Loading

✅ Deploy Preview for open-event-checkin ready!

mariobehling commented Jun 27, 2024

Sak1012 commented Jul 2, 2024

Screen Shots

Sak1012 commented Jul 20, 2024

mariobehling commented Jul 22, 2024

sourcery-ai bot commented Jul 22, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot Jul 22, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 22, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 22, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 22, 2024

Choose a reason for hiding this comment

mariobehling commented Jul 24, 2024

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot Jul 24, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 18, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Jul 24, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 18, 2024

Choose a reason for hiding this comment

sourcery-ai bot Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hongquan commented Aug 19, 2024

Sak1012 commented Oct 14, 2024

Sak1012 commented Oct 18, 2024

Sak1012 commented Oct 29, 2024

Choose a reason for hiding this comment

Sak1012 commented Jun 26, 2024 •

edited

Loading

netlify bot commented Jun 26, 2024 •

edited

Loading

sourcery-ai bot commented Jul 22, 2024 •

edited

Loading