Add rows lint

Author: victorbotamedi

analysis_options.yaml

@@ -1,4 +1 @@
-include: package:flutter_lints/flutter.yaml
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+include: package:rows_lint/analysis_options.yaml

example/analysis_options.yaml

@@ -1,29 +1 @@
-# This file configures the analyzer, which statically analyzes Dart code to
-# check for errors, warnings, and lints.
-#
-# The issues identified by the analyzer are surfaced in the UI of Dart-enabled
-# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
-# invoked from the command line by running `flutter analyze`.
-
-# The following line activates a set of recommended lints for Flutter apps,
-# packages, and plugins designed to encourage good coding practices.
-include: package:flutter_lints/flutter.yaml
-
-linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at
-  # https://dart-lang.github.io/linter/lints/index.html.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
-  rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+include: package:rows_lint/analysis_options.yaml

example/lib/main.dart

@@ -31,7 +31,7 @@ class MyHomePage extends StatelessWidget {
   Widget build(BuildContext context) {
     return Scaffold(
       appBar: AppBar(
-        title: const Text("Test Data Explorer"),
+        title: const Text('Test Data Explorer'),
       ),
       body: ListView(
         padding: const EdgeInsets.all(16),
@@ -117,7 +117,7 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
 
   @override
   void initState() {
-    loadJsonDataFrom(widget.jsonUrl);
+    _loadJsonDataFrom(widget.jsonUrl);
     super.initState();
   }
 
@@ -141,7 +141,6 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
                       child: TextField(
                         controller: searchController,
                         onChanged: (term) => state.search(term),
-                        maxLines: 1,
                         decoration: const InputDecoration(
                           hintText: 'Search',
                         ),
@@ -151,21 +150,20 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
                       width: 8,
                     ),
                     if (state.searchResults.isNotEmpty)
-                      Text(
-                          '${state.focusedSearchResultIndex + 1} of ${state.searchResults.length}'),
+                      Text(_searchFocusText()),
                     if (state.searchResults.isNotEmpty)
                       IconButton(
                         onPressed: () {
                           store.focusPreviousSearchResult();
-                          scrollToSearchMatch();
+                          _scrollToSearchMatch();
                         },
                         icon: const Icon(Icons.arrow_drop_up),
                       ),
                     if (state.searchResults.isNotEmpty)
                       IconButton(
                         onPressed: () {
                           store.focusNextSearchResult();
-                          scrollToSearchMatch();
+                          _scrollToSearchMatch();
                         },
                         icon: const Icon(Icons.arrow_drop_down),
                       ),
@@ -215,7 +213,7 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
                         ),
                         child: Text(
                           node.isClass
-                              ? '{${(node.childrenCount)}}'
+                              ? '{${node.childrenCount}}'
                               : '[${node.childrenCount}]',
                           style: GoogleFonts.inconsolata(
                             fontSize: 12,
@@ -252,7 +250,7 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
                         : const SizedBox(),
 
                     /// Creates a custom format for classes and array names.
-                    rootNameFormatter: (name) => '$name',
+                    rootNameFormatter: (dynamic name) => '$name',
 
                     /// Theme definitions of the json data explorer
                     theme: DataExplorerTheme(
@@ -309,11 +307,14 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
     );
   }
 
-  Future loadJsonDataFrom(String url) async {
+  String _searchFocusText() =>
+      '${store.focusedSearchResultIndex + 1} of ${store.searchResults.length}';
+
+  Future _loadJsonDataFrom(String url) async {
     debugPrint('Calling Json API');
     final data = await http.read(Uri.parse(url));
     debugPrint('Done!');
-    var decoded = json.decode(data);
+    final dynamic decoded = json.decode(data);
     store.buildNodes(decoded, areAllCollapsed: true);
   }
 
@@ -326,7 +327,7 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
     debugPrint('${node.key}: ${node.value}');
   }
 
-  void scrollToSearchMatch() {
+  void _scrollToSearchMatch() {
     final index = store.displayNodes.indexOf(store.focusedSearchResult.node);
     if (index != -1) {
       itemScrollController.scrollTo(
@@ -362,7 +363,7 @@ class _OpenJsonButton extends StatelessWidget {
         padding: padding,
         child: ElevatedButton(
           child: Text(title),
-          onPressed: () => Navigator.of(context).push(
+          onPressed: () => Navigator.of(context).push<MaterialPageRoute>(
             MaterialPageRoute(
               builder: (ctx) => DataExplorerPage(
                 jsonUrl: url,

example/pubspec.lock

@@ -50,6 +50,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "3.0.1"
+  effective_dart:
+    dependency: transitive
+    description:
+      name: effective_dart
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.3.2"
   fake_async:
     dependency: transitive
     description:
@@ -76,13 +83,6 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
-  flutter_lints:
-    dependency: "direct dev"
-    description:
-      name: flutter_lints
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "1.0.4"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -128,13 +128,6 @@ packages:
       relative: true
     source: path
     version: "0.0.1"
-  lints:
-    dependency: transitive
-    description:
-      name: lints
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "1.0.1"
   matcher:
     dependency: transitive
     description:
@@ -247,6 +240,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "6.0.2"
+  rows_lint:
+    dependency: "direct dev"
+    description:
+      name: rows_lint
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.1.0"
   scrollable_positioned_list:
     dependency: transitive
     description:

example/pubspec.yaml

@@ -18,7 +18,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  flutter_lints: ^1.0.0
+  rows_lint: 0.1.0
 
 flutter:
   uses-material-design: true

lib/src/data_explorer_store.dart

@@ -161,19 +161,19 @@ class NodeViewModelState extends ChangeNotifier {
   /// Sets the highlight property of this node and all of its children.
   ///
   /// [notifyListeners] is called to notify all registered listeners.
-  void highlight(bool highlight) {
-    _isHighlighted = highlight;
-    for (var children in children) {
-      children.highlight(highlight);
+  void highlight({bool isHighlighted = true}) {
+    _isHighlighted = isHighlighted;
+    for (final children in children) {
+      children.highlight(isHighlighted: isHighlighted);
     }
     notifyListeners();
   }
 
   /// Sets the focus property of this node.
   ///
   /// [notifyListeners] is called to notify all registered listeners.
-  void focus(bool focus) {
-    _isFocused = focus;
+  void focus({bool isFocused = true}) {
+    _isFocused = isFocused;
     notifyListeners();
   }
 
@@ -204,15 +204,15 @@ Map<String, NodeViewModelState> buildViewModelNodes(dynamic object) {
   if (object is Map<String, dynamic>) {
     return _buildClassNodes(object: object);
   }
-  return _buildClassNodes(object: {'data': object});
+  return _buildClassNodes(object: <String, dynamic>{'data': object});
 }
 
 Map<String, NodeViewModelState> _buildClassNodes({
   required Map<String, dynamic> object,
   int treeDepth = 0,
 }) {
   final map = <String, NodeViewModelState>{};
-  object.forEach((key, value) {
+  object.forEach((key, dynamic value) {
     if (value is Map<String, dynamic>) {
       final subClass = _buildClassNodes(
         object: value,
@@ -249,8 +249,8 @@ List<NodeViewModelState> _buildArrayNodes({
   int treeDepth = 0,
 }) {
   final array = <NodeViewModelState>[];
-  for (int i = 0; i < object.length; i++) {
-    final arrayValue = object[i];
+  for (var i = 0; i < object.length; i++) {
+    final dynamic arrayValue = object[i];
 
     if (arrayValue is Map<String, dynamic>) {
       final classNode = _buildClassNodes(
@@ -292,9 +292,11 @@ List<NodeViewModelState> _flattenClass(Map<String, NodeViewModelState> object) {
 
     if (!value.isCollapsed) {
       if (value.value is Map) {
-        flatList.addAll(_flattenClass(value.value));
+        flatList.addAll(
+          _flattenClass(value.value as Map<String, NodeViewModelState>),
+        );
       } else if (value.value is List) {
-        flatList.addAll(_flattenArray(value.value));
+        flatList.addAll(_flattenArray(value.value as List<NodeViewModelState>));
       }
     }
   });
@@ -307,7 +309,9 @@ List<NodeViewModelState> _flattenArray(List<NodeViewModelState> objects) {
     flatList.add(object);
     if (!object.isCollapsed &&
         object.value is Map<String, NodeViewModelState>) {
-      flatList.addAll(_flattenClass(object.value));
+      flatList.addAll(
+        _flattenClass(object.value as Map<String, NodeViewModelState>),
+      );
     }
   }
   return flatList;
@@ -574,7 +578,7 @@ class DataExplorerStore extends ChangeNotifier {
 
   int _visibleChildrenCount(NodeViewModelState node) {
     final children = node.children;
-    int count = 1;
+    var count = 1;
     for (final child in children) {
       count =
           child.isCollapsed ? count + 1 : count + _visibleChildrenCount(child);

lib/src/data_explorer_theme.dart

@@ -176,8 +176,12 @@ class DataExplorerTheme {
 
   @override
   bool operator ==(Object other) {
-    if (identical(this, other)) return true;
-    if (other.runtimeType != runtimeType) return false;
+    if (identical(this, other)) {
+      return true;
+    }
+    if (other.runtimeType != runtimeType) {
+      return false;
+    }
     return other is DataExplorerTheme &&
         rootKeyTextStyle == other.rootKeyTextStyle &&
         propertyKeyTextStyle == other.propertyKeyTextStyle &&