Skip to content
This repository was archived by the owner on Nov 28, 2024. It is now read-only.

Commit b23fcb8

Browse files
authored
improv: rename isAllCollapsed to areAllCollapsed
1 parent 3fd4453 commit b23fcb8

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

example/lib/main.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ class _DataExplorerPageState extends State<DataExplorerPage> {
314314
final data = await http.read(Uri.parse(url));
315315
debugPrint('Done!');
316316
var decoded = json.decode(data);
317-
store.buildNodes(decoded, isAllCollapsed: true);
317+
store.buildNodes(decoded, areAllCollapsed: true);
318318
}
319319

320320
void _printNode(NodeViewModelState node) {

lib/src/data_explorer_store.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -555,17 +555,17 @@ class DataExplorerStore extends ChangeNotifier {
555555

556556
/// Uses the given [jsonObject] to build the [displayNodes] list.
557557
///
558-
/// If [isAllCollapsed] is true, then all nodes will be collapsed, and
558+
/// If [areAllCollapsed] is true, then all nodes will be collapsed, and
559559
/// initially only upper root nodes will be in the list.
560560
///
561561
/// [notifyListeners] is called to notify all registered listeners.
562-
Future buildNodes(dynamic jsonObject, {bool isAllCollapsed = false}) async {
562+
Future buildNodes(dynamic jsonObject, {bool areAllCollapsed = false}) async {
563563
final builtNodes = buildViewModelNodes(jsonObject);
564564
final flatList = flatten(builtNodes);
565565

566566
_allNodes = UnmodifiableListView(flatList);
567567
_displayNodes = List.from(flatList);
568-
if (isAllCollapsed) {
568+
if (areAllCollapsed) {
569569
collapseAll();
570570
} else {
571571
notifyListeners();

test/unit/data_explorer_store_test.dart

+17-17
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void main() {
8585

8686
test('build all collapsed nodes', () {
8787
final store = DataExplorerStore();
88-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
88+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
8989
expect(store.displayNodes, hasLength(2));
9090
expect(store.displayNodes.elementAt(0).key, 'firstClass');
9191
expect(store.displayNodes.elementAt(1).key, 'secondClass');
@@ -107,7 +107,7 @@ void main() {
107107
final listener = MockCallbackFunction();
108108
store.addListener(listener);
109109

110-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
110+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
111111
verify(() => listener.call()).called(1);
112112
});
113113

@@ -130,7 +130,7 @@ void main() {
130130

131131
test('expand all nodes', () {
132132
final store = DataExplorerStore();
133-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
133+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
134134

135135
final listener = MockCallbackFunction();
136136
store.addListener(listener);
@@ -181,7 +181,7 @@ void main() {
181181

182182
test("collapse won't do anything for already collapsed nodes", () {
183183
final store = DataExplorerStore();
184-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
184+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
185185
expect(store.displayNodes, hasLength(2));
186186

187187
final listener = MockCallbackFunction();
@@ -196,7 +196,7 @@ void main() {
196196

197197
test('expand node', () {
198198
final store = DataExplorerStore();
199-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
199+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
200200

201201
final listener = MockCallbackFunction();
202202
store.addListener(listener);
@@ -215,7 +215,7 @@ void main() {
215215

216216
test("expand won't do anything for non root nodes", () {
217217
final store = DataExplorerStore();
218-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
218+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
219219
store.expandNode(store.displayNodes.first);
220220
expect(store.displayNodes, hasLength(8));
221221

@@ -284,26 +284,26 @@ void main() {
284284
});
285285

286286
group('areAllCollapsed', () {
287-
test('works properly when nodes are built with isAllCollapsed as false',
287+
test('works properly when nodes are built with areAllCollapsed as false',
288288
() {
289289
final store = DataExplorerStore();
290-
store.buildNodes(json.decode(testJson), isAllCollapsed: false);
290+
store.buildNodes(json.decode(testJson), areAllCollapsed: false);
291291

292292
expect(store.areAllCollapsed(), isFalse);
293293
});
294294

295-
test('works properly when nodes are built with isAllCollapsed as true',
295+
test('works properly when nodes are built with areAllCollapsed as true',
296296
() {
297297
final store = DataExplorerStore();
298-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
298+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
299299

300300
expect(store.areAllCollapsed(), isTrue);
301301
});
302302

303303
test('''works properly when collapsing a root class child that has
304304
inner classes that are not collapsed''', () {
305305
final store = DataExplorerStore();
306-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
306+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
307307

308308
store.expandNode(store.getNodeByKey('firstClass'));
309309
store.expandNode(store.getNodeByKey('firstClass.firstClassField'));
@@ -319,7 +319,7 @@ void main() {
319319

320320
test('works properly when collapsing each node individually', () {
321321
final store = DataExplorerStore();
322-
store.buildNodes(json.decode(testJson), isAllCollapsed: false);
322+
store.buildNodes(json.decode(testJson), areAllCollapsed: false);
323323

324324
expect(store.areAllCollapsed(), isFalse);
325325

@@ -361,25 +361,25 @@ void main() {
361361
});
362362

363363
group('areAllExpanded', () {
364-
test('works properly when nodes are built with isAllCollapsed as false',
364+
test('works properly when nodes are built with areAllCollapsed as false',
365365
() {
366366
final store = DataExplorerStore();
367-
store.buildNodes(json.decode(testJson), isAllCollapsed: false);
367+
store.buildNodes(json.decode(testJson), areAllCollapsed: false);
368368

369369
expect(store.areAllExpanded(), isTrue);
370370
});
371371

372-
test('works properly when nodes are built with isAllCollapsed as true',
372+
test('works properly when nodes are built with areAllCollapsed as true',
373373
() {
374374
final store = DataExplorerStore();
375-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
375+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
376376

377377
expect(store.areAllExpanded(), isFalse);
378378
});
379379

380380
test('works properly when expanding each node individually', () {
381381
final store = DataExplorerStore();
382-
store.buildNodes(json.decode(testJson), isAllCollapsed: true);
382+
store.buildNodes(json.decode(testJson), areAllCollapsed: true);
383383

384384
expect(store.areAllExpanded(), isFalse);
385385

0 commit comments

Comments
 (0)