-
Notifications
You must be signed in to change notification settings - Fork 535
Turning textfield multiline #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…one as per instructions
@TeeWrath Hey, really appreciate your first contribution to API Dash — welcome aboard! .I noticed you added Just try typing a long text in the Google Search bar as @animator provides the example image — it expands while editing, then resets to its original size on focus loss. |
Thank you so much for such a warm welcome and your review @BalaSubramaniam12007 and @animator . I totally understand the importance of good UX and as per your suggestion, I have used the I have also set the To further smoothen the UX I have wrapped the below is a video demonstration of how it looks now: multiline.mp4Please let me know if any changes are required further. |
@TeeWrath yeah it looks good also when the send button is clicked then also it should go to normal state then it would be perfect |
@WannaCry016 @BalaSubramaniam12007 Should I move forward with a similar pattern for other TextFields too ? |
Test this feature in mobile. |
@animator @BalaSubramaniam12007 Hi, as per the directions given to me, I have implemented multi-line textfields for :
The fields revert back to 1 liners when not focused upon and are multi-line during editing, as per the desired UX. @animator on testing on mobile I found that this works on mobile too. I am attaching a screen recording here for the reference. multi-line.mobile.mp4Next I will implement similar multi-line functionality in the Request name text field in the collection pane. |
That’s great to hear! The output looks good to me as well. Just have a quick discussion with the mentors @animator sir @ashitaprasad mam and confirm the expected outcome and align on any final tweaks. |
With this commit, I have also turned the side pane search field to multi-line while following the pattern recommended. A preview : Current checklist:
I request @animator sir and @ashitaprasad mam to review this and give me further instructions if any for improvement. Thank you. |
In the demo video, for the URL it is fine, but the variable implementation is not useful .. what is the point of having it multiline if all the text content is not visible and you have to scroll vertically inside the text field. |
I was thinking the same, @TeeWrath . For your extra reference, please see how Postman handles this . |
@BalaSubramaniam12007 @animator Right sir, I will adjust this as per your suggestions. I will try to make it look similar to how it is on Postman. Have an exam tomorrow, will fix this after coming back. Thank you. |
…ne, need cursor and interaction yet
@animator hello sir, I have implemented an overlay kind of like it is in postman for the variable textfields. Would be great if you could give some reviews on it. Preview is below. var.mp4 |
@TeeWrath Test it on mobile and upload video. |
@animator I noticed a small glitch in the mobile version. Working on it. |
Hi @animator
PR Description
This is in reference to the issue #826 recently opened. I have started applying this the textfields present throughout the app. First I started with the text field in URL card. After my changes, it looks like this:
I will move forward with other textfield, while I would love to get reviews on this. I am contributing to API Dash for the first time, hence I'm planning to move ahead with reviews.
Next I will focus on:
EnvironmentTriggerField
which I already modified to multi-line for the url field.)Checklist
main
branch before making this PRflutter upgrade
and verify)flutter test
) and all tests are passingOS on which you have developed and tested the feature?