Skip to content

Add container_image at the workflow level. #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RRap0so
Copy link
Contributor

@RRap0so RRap0so commented Apr 11, 2025

The container_image should be propagated to all underlying levels of a task.

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

The container_image should be propagated to all underlying levels of a task.

Signed-off-by: Rafael Raposo <[email protected]>
@flyte-bot
Copy link
Contributor

flyte-bot commented Apr 11, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Draft PR

    Bito didn't auto-review because this pull request is in draft status.
    To trigger review, mark the PR as ready or type /review in the comment and save.
    You can change draft PR review settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.69%. Comparing base (8abecfe) to head (0adc893).

Files with missing lines Patch % Lines
flytekit/core/workflow.py 80.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8abecfe) and HEAD (0adc893). Click for more details.

HEAD has 25 uploads less than BASE
Flag BASE (8abecfe) HEAD (0adc893)
27 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3226       +/-   ##
===========================================
- Coverage   90.00%   46.69%   -43.32%     
===========================================
  Files         133      214       +81     
  Lines        6404    22304    +15900     
  Branches        0     2924     +2924     
===========================================
+ Hits         5764    10414     +4650     
- Misses        640    11361    +10721     
- Partials        0      529      +529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RRap0so RRap0so force-pushed the rafael/add-container-image-workflow branch 3 times, most recently from 19cad35 to 3c4a26a Compare April 11, 2025 19:30
@flyte-bot
Copy link
Contributor

flyte-bot commented Apr 11, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Automatic Review Skipped - Draft PR

    Bito didn't auto-review because this pull request is in draft status.
    To trigger review, mark the PR as ready or type /review in the comment and save.
    You can change draft PR review settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants