Skip to content

Fix: Fixed crash that would occur when using an invalid background image #17083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 29, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Manually set AppThemeBackgroundImageSource to an invalid value (eg 'a')
  2. Confirm Files starts correctly

@yaira2 yaira2 force-pushed the ya/System.ArgumentException branch from 0812db0 to 34a5f59 Compare April 29, 2025 23:38
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 29, 2025
@yaira2 yaira2 merged commit 06489eb into main Apr 29, 2025
8 checks passed
@yaira2 yaira2 deleted the ya/System.ArgumentException branch April 29, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: AppThemeBackgroundImageSource System.ArgumentException
1 participant