Skip to content

feat: implement encoding.TextMarshaler/Unmarshaler for EthUint64 #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Apr 25, 2025

No description provided.

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 25, 2025
@Kubuxu Kubuxu added the skip/changelog This change does not require CHANGELOG.md update label Apr 25, 2025
*e = EthUint64(eint)
return nil
// if string literal, remove quotes
if b[0] == '"' && b[len(b)-1] == '"' {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use json.Unmarshal. This won't handle:

  1. Strings < 2 bytes.
  2. JSON escape sequences.

Etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% missed the slice lengts, will do

@github-project-automation github-project-automation bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Apr 25, 2025
@BigLep
Copy link
Member

BigLep commented May 20, 2025

@Kubuxu : I'm marking this as draft until feedback is incorporated. Then mark it ready for review so it's clear that others should look.

@BigLep BigLep marked this pull request as draft May 20, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ⌨️ In Progress
Development

Successfully merging this pull request may close these issues.

3 participants