Skip to content

chore(deps): bump filecoin-ffi for [email protected] #13029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 11, 2025

This is just current master of filecoin-ffi, this commit in particular, unreleased as yet. This upgrades FVM to v4.7 (and v3 and v2 have had updates) which, among other things, bump wasmtime and switch scep256k1 libraries. The releases shouldn't be consensus breaking but need to be tested on mainnet. Probably should be tested with a calibnet resync from genesis too.

This is also needed for #12822.

@BigLep
Copy link
Member

BigLep commented May 5, 2025

@rvagg : what is needed to make this ready for review?

@BigLep BigLep moved this from 📌 Triage to ⌨️ In Progress in FilOz May 5, 2025
@rvagg rvagg force-pushed the rvagg/fvm-4.7 branch from e3b5fad to cb320e5 Compare May 8, 2025 19:14
@rvagg rvagg marked this pull request as ready for review May 8, 2025 19:14
@rvagg
Copy link
Member Author

rvagg commented May 8, 2025

Rebased on current master and updated to the new v1.33.1-dev tag 🥳 .

@rvagg rvagg requested review from TippyFlitsUK and rjan90 May 8, 2025 19:15
@rvagg rvagg changed the title chore(deps): bump filecoin-ffi for [email protected] (DRAFT) chore(deps): bump filecoin-ffi for [email protected] May 8, 2025
@rvagg
Copy link
Member Author

rvagg commented May 8, 2025

whoops, this isn't complete, I forgot that I need to pull in a bit more code from #12822 to handle the new return type

@rvagg rvagg force-pushed the rvagg/fvm-4.7 branch from cb320e5 to 3cc4a09 Compare May 8, 2025 20:16
@rvagg rvagg force-pushed the rvagg/fvm-4.7 branch from 3cc4a09 to 4775326 Compare May 8, 2025 20:27
@rvagg
Copy link
Member Author

rvagg commented May 8, 2025

should be gtg now

@github-project-automation github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz May 8, 2025
@rvagg rvagg merged commit 54bd2c7 into master May 9, 2025
96 checks passed
@rvagg rvagg deleted the rvagg/fvm-4.7 branch May 9, 2025 14:06
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

4 participants