Skip to content

Update permissions of the "proofs" team from PL Inc / Elliptic Research days #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2025

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented May 22, 2025

Summary

This is handling the "Adjust membership of the "proofs" team" and "Remove cases where..." steps of #132

Why do you need this?

#132

Steps

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

BigLep and others added 4 commits May 22, 2025 12:29
This is handling the "archive the repos", "remove direct collaborators", and "reduce permissions generally" steps of #132
…ch days

This is handling the "Adjust membership of the "proofs" team" and "Remove cases where..." steps of #132
Copy link

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @cryptonemo should also be removed from lotus-contributors and @DrPeterVanNostrand should be added to alumni.

@BigLep
Copy link
Member Author

BigLep commented May 27, 2025

I guess @cryptonemo should also be removed from lotus-contributors and @DrPeterVanNostrand should be added to alumni.

Thanks. Done in 31a7f30

@BigLep BigLep changed the base branch from biglep/update-proofs-permissions to master May 29, 2025 20:47
@BigLep BigLep marked this pull request as ready for review May 29, 2025 20:50
@BigLep BigLep requested a review from a team as a code owner May 29, 2025 20:50
Copy link
Contributor

github-actions bot commented May 29, 2025

The following access changes will be introduced as a result of applying the plan:

Access Changes
User cryptonemo:
  - will lose push permission to builtin-actors
  - will lose push permission to dagstore
  - will lose push permission to dealbot
  - will lose push permission to ff-bounties
  - will lose push permission to ffi-stub
  - will lose push permission to fvm-test-vectors
  - will lose push permission to go-bitfield
  - will lose push permission to go-commp-utils
  - will lose push permission to go-data-segment
  - will lose push permission to go-data-transfer
  - will lose push permission to go-ds-versioning
  - will lose push permission to go-fil-commcid
  - will lose push permission to go-fil-commp-hashhash
  - will lose push permission to go-fil-markets
  - will lose push permission to go-state-types
  - will lose push permission to go-statemachine
  - will lose push permission to lotus
  - will lose push permission to lotus-docs
  - will lose push permission to lotus-infra-dev
  - will lose push permission to ref-fvm
  - will lose push permission to sentinel-tick
User drpetervannostrand:
  - will lose push permission to bellperson
  - will lose push permission to bls-signatures
  - will lose maintain permission to blstrs
  - will lose maintain permission to ec-gpu
  - will lose push permission to fil-rustacuda
  - will lose push permission to filecoin-explorer
  - will lose admin permission to filecoin-ffi
  - will lose admin permission to filecoin-ffi-private
  - will lose triage permission to filecoin.io
  - will lose push permission to fips
  - will lose pull permission to fvm-pm
  - will lose push permission to go-paramfetch
  - will lose push permission to lotus-infra-dev
  - will lose push permission to merkletree
  - will lose push permission to powersoftau
  - will lose maintain permission to rust-fil-logger
  - will lose push permission to rust-fil-proofs
  - will lose maintain permission to rust-filecoin-proofs-api
  - will lose push permission to rust-gpu-tools
  - will lose pull permission to sentinel
  - will lose push permission to specs
  - will lose pull permission to taupipp
User porcuquine:
  - will lose push permission to bellperson
  - will lose push permission to bls-signatures
  - will lose maintain permission to blstrs
  - will lose maintain permission to ec-gpu
  - will lose push permission to fil-rustacuda
  - will lose push permission to filecoin-explorer
  - will lose admin permission to filecoin-ffi
  - will lose admin permission to filecoin-ffi-private
  - will lose push permission to go-paramfetch
  - will lose push permission to merkletree
  - will lose push permission to powersoftau
  - will lose maintain permission to rust-fil-logger
  - will lose push permission to rust-fil-proofs
  - will lose maintain permission to rust-filecoin-proofs-api
  - will lose push permission to rust-gpu-tools
  - will lose maintain permission to specs
  - will lose pull permission to taupipp
User vmx:
  - will lose push permission to filecoin-explorer
  - will lose push permission to lotus-infra-dev
  - will lose push permission to specs

Copy link
Contributor

github-actions bot commented May 29, 2025

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # github_repository_collaborator.this["fvm-pm:drpetervannostrand"] will be destroyed
  # (because key ["fvm-pm:drpetervannostrand"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "fvm-pm:DrPeterVanNostrand" -> null
      - permission = "pull" -> null
      - repository = "fvm-pm" -> null
      - username   = "DrPeterVanNostrand" -> null
    }

  # github_repository_collaborator.this["lotus-infra-dev:cryptonemo"] will be destroyed
  # (because key ["lotus-infra-dev:cryptonemo"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "lotus-infra-dev:cryptonemo" -> null
      - permission = "push" -> null
      - repository = "lotus-infra-dev" -> null
      - username   = "cryptonemo" -> null
    }

  # github_repository_collaborator.this["lotus-infra-dev:drpetervannostrand"] will be destroyed
  # (because key ["lotus-infra-dev:drpetervannostrand"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "lotus-infra-dev:DrPeterVanNostrand" -> null
      - permission = "push" -> null
      - repository = "lotus-infra-dev" -> null
      - username   = "DrPeterVanNostrand" -> null
    }

  # github_repository_collaborator.this["lotus-infra-dev:vmx"] will be destroyed
  # (because key ["lotus-infra-dev:vmx"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "lotus-infra-dev:vmx" -> null
      - permission = "push" -> null
      - repository = "lotus-infra-dev" -> null
      - username   = "vmx" -> null
    }

  # github_team_membership.this["alumni:drpetervannostrand"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "7328025"
      + username = "DrPeterVanNostrand"
    }

  # github_team_membership.this["dev-misc:drpetervannostrand"] will be destroyed
  # (because key ["dev-misc:drpetervannostrand"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"702dfd2cdc77056c8c8f810e88e11caa83f41620af67e7b5b651826e9cf82016\"" -> null
      - id       = "2584134:DrPeterVanNostrand" -> null
      - role     = "member" -> null
      - team_id  = "2584134" -> null
      - username = "DrPeterVanNostrand" -> null
    }

  # github_team_membership.this["dev-misc:porcuquine"] will be destroyed
  # (because key ["dev-misc:porcuquine"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"351d83b40d660f158d6441c7ab4908d996ec2e5e2f0257f73a0f8557b9fed86c\"" -> null
      - id       = "2584134:porcuquine" -> null
      - role     = "member" -> null
      - team_id  = "2584134" -> null
      - username = "porcuquine" -> null
    }

  # github_team_membership.this["dev-misc:vmx"] will be destroyed
  # (because key ["dev-misc:vmx"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"a374535ac6fa8270bc700b2928ac160cc8b2751a3eea9558c24760242716a50c\"" -> null
      - id       = "2584134:vmx" -> null
      - role     = "member" -> null
      - team_id  = "2584134" -> null
      - username = "vmx" -> null
    }

  # github_team_membership.this["lotus-contributors:cryptonemo"] will be destroyed
  # (because key ["lotus-contributors:cryptonemo"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"94a8dac4fa3b41c60ba87eede3f31bccbb57884618f684543f26f68c377c570c\"" -> null
      - id       = "7328060:cryptonemo" -> null
      - role     = "member" -> null
      - team_id  = "7328060" -> null
      - username = "cryptonemo" -> null
    }

  # github_team_membership.this["proj-mgmt:porcuquine"] will be destroyed
  # (because key ["proj-mgmt:porcuquine"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"007ed87e77a524959e8f87325da586973ca55f6d93bd2403d811ec2d2743881a\"" -> null
      - id       = "3057781:porcuquine" -> null
      - role     = "member" -> null
      - team_id  = "3057781" -> null
      - username = "porcuquine" -> null
    }

  # github_team_membership.this["proofs:cryptonemo"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "3076505:cryptonemo"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["proofs:drpetervannostrand"] will be destroyed
  # (because key ["proofs:drpetervannostrand"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"ae7d951e9c1ab1b78f1d7f57c60f993024be957ad9fe2dc20b93c0a51d19970d\"" -> null
      - id       = "3076505:DrPeterVanNostrand" -> null
      - role     = "member" -> null
      - team_id  = "3076505" -> null
      - username = "DrPeterVanNostrand" -> null
    }

  # github_team_membership.this["proofs:kubuxu"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "3076505:Kubuxu"
      ~ role     = "member" -> "maintainer"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["proofs:porcuquine"] will be destroyed
  # (because key ["proofs:porcuquine"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"4d6186c88ef5a8a99f2009e1be27a82926a26bfb6621919e1a99e9a7b9d99ebf\"" -> null
      - id       = "3076505:porcuquine" -> null
      - role     = "member" -> null
      - team_id  = "3076505" -> null
      - username = "porcuquine" -> null
    }

  # github_team_membership.this["proofs:rvagg"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "3076505"
      + username = "rvagg"
    }

  # github_team_membership.this["proofs:zenground0"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "3076505"
      + username = "ZenGround0"
    }

  # github_team_membership.this["research:drpetervannostrand"] will be destroyed
  # (because key ["research:drpetervannostrand"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"89aba8f58498ae85c951466d17291b96bde5574587fe3f800da1458e309c4b82\"" -> null
      - id       = "2545542:DrPeterVanNostrand" -> null
      - role     = "member" -> null
      - team_id  = "2545542" -> null
      - username = "DrPeterVanNostrand" -> null
    }

  # github_team_membership.this["specs:porcuquine"] will be destroyed
  # (because key ["specs:porcuquine"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"362ca110edd5653159f24216ba40042b30b932426f29c17819c1f6c845e14eb0\"" -> null
      - id       = "2518866:porcuquine" -> null
      - role     = "member" -> null
      - team_id  = "2518866" -> null
      - username = "porcuquine" -> null
    }

Plan: 3 to add, 2 to change, 13 to destroy.

Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BigLep
Copy link
Member Author

BigLep commented May 30, 2025

I can take care of closing this out on 2025-06-03 (i.e., merging this and @mentioning those who will be impacted). Otherws are welcome to do so sooner as well.

@BigLep
Copy link
Member Author

BigLep commented Jun 3, 2025

@cryptonemo @DrPeterVanNostrand @porcuquine @vmx: FYI that your "proofs" repo access will be getting updated. See #134 (comment)

@BigLep BigLep merged commit 5bb236f into master Jun 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants