[FIL-146] Allow triggering refill even if less than 75% of the DataCap was used #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Filip-L
commented
May 28, 2025
Filip-L
commented
| @@ -222,6 +225,25 @@ const DatacapAmountModal = ({ | |||
| </Box> | |||
| </div> | |||
| </div> | |||
| {usedDatatapInPercentage < 75 && | |||
| remainingDatacap && | |||
| remainingDatacap > 0 ? ( | |||
There was a problem hiding this comment.
[nitpick] Kinda redundant, the line above will already return false when coerced to boolean for remainingDatacap equal to 0
| rows={4} | ||
| variant="outlined" | ||
| fullWidth | ||
| onChange={(e: React.ChangeEvent<HTMLInputElement>) => { |
| @@ -233,7 +255,14 @@ const DatacapAmountModal = ({ | |||
| Cancel | |||
| </Button> | |||
| <Button | |||
| disabled={isApiCalling || !allocationConfig.amount} | |||
| disabled={ | |||
There was a problem hiding this comment.
Might be good idea to define a constant for readability reasons instead of inlining so many condition
tmaciej-neti
approved these changes
May 28, 2025
Filip-L
deleted the
FIL-146-allow-triggering-refill-even-if-less-than-75%-of-the-datacap-was-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.