[FIL-837] Add countdown and change default allocation type #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
force-pushed
the
FIL-837-add-countdown-and-change-default
branch
from
0f9ada5 to
8115719
Compare
Filip-L
requested review from
tmaciej-neti and
kacperzuk-neti
and removed request for
tmaciej-neti
kacperzuk-neti
requested changes
May 8, 2025
src/components/Countdown.tsx
Outdated
Comment on lines
68
to
72
| Direct client allocation will be deprecated in{' '} | ||
| <span className="inline-block text-center" style={{ width: '90px' }}> | ||
| {timeLeft.days}:{timeLeft.hours}:{timeLeft.minutes}:{timeLeft.seconds} | ||
| </span> | ||
| . Start using the Client smart contract today. |
There was a problem hiding this comment.
Suggested change
| Direct client allocation will be deprecated in{' '} | |
| <span className="inline-block text-center" style={{ width: '90px' }}> | |
| {timeLeft.days}:{timeLeft.hours}:{timeLeft.minutes}:{timeLeft.seconds} | |
| </span> | |
| . Start using the Client smart contract today. | |
| Direct allocation of DataCap will be deprecated in{' '} | |
| <span class="whitespace-nowrap">{timeLeft.days} days</span> (June 1). Start using the Client smart contract today. |
Reasons:
- Numbers in countdown are confusing.
24:10:24:02? Users will need to guess what it means - Some (me :D) will prefer explicit date.
Direct client allocationsounds confusing. We're not allocating clients, we're allocating datacap.- Why the fixed width and inline-block and text-center? I assume it was to prevent breaking the text over new line.
whitespace-nowrapseems better for that purpose. If the reason was different please explain.
src/components/Countdown.tsx
Outdated
Comment on lines
68
to
72
| Direct client allocation will be deprecated in{' '} | ||
| <span className="inline-block text-center" style={{ width: '90px' }}> | ||
| {timeLeft.days}:{timeLeft.hours}:{timeLeft.minutes}:{timeLeft.seconds} | ||
| </span> | ||
| . Start using the Client smart contract today. |
There was a problem hiding this comment.
We need to add a link to instruction/more in-depth explanation.
There was a problem hiding this comment.
The link to the instructions will be added once the instructions are ready.
src/components/cards/AppInfoCard.tsx
Outdated
| @@ -1046,6 +1046,7 @@ const AppInfoCard: React.FC<ComponentProps> = ({ | |||
| /> | |||
| )} | |||
| </CardContent> | |||
| <Countdown /> | |||
There was a problem hiding this comment.
Let's move it to the modal where allocator chooses contract vs direct.
tmaciej-neti
reviewed
May 8, 2025
src/components/Countdown.tsx
Outdated
| } | ||
| }, []) | ||
|
|
||
| if (!isMounted) { |
There was a problem hiding this comment.
Any reason to do that?
kacperzuk-neti
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.