[FIL-760] Add button to reopen decline application #194
Conversation
Filip-L
changed the title
src/components/cards/AppInfoCard.tsx
Outdated
| session?.data?.user?.name !== undefined && | ||
| application?.Lifecycle?.['On Chain Address'] && | ||
| application?.['Client Contract Address'] && | ||
| ['ChangingSP'].includes(application?.Lifecycle?.State) && ( |
There was a problem hiding this comment.
Simple equality check would suffice
| ['ChangingSP'].includes(application?.Lifecycle?.State) && ( | ||
| <div className="flex gap-2"> | ||
| <Button | ||
| onClick={() => { |
There was a problem hiding this comment.
onClick={handleApproveAllowedSPs}
| { userName: string }, | ||
| unknown | ||
| >( | ||
| async ({ userName }) => { |
There was a problem hiding this comment.
[Minor] No need to use async just to await straight away. Simply returning a promise would be ok.
| }, | ||
| { | ||
| onSuccess: (data) => { | ||
| setApiCalling(false) |
There was a problem hiding this comment.
useMutation already returns property isPending to track if the mutation is running, no need to track the state separately.
There was a problem hiding this comment.
This component could really use a refactor to break it down into multiple components. It's getting pretty unreadable with all the conditional rendering. At the very least moving the conditions to a const eg.
const shouldRenderThisAndThat = // all the checks here
instead of inlining them everywhere would improve readability considerably.
No description provided.