-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add configurable Content Security Policy (CSP) support #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add --csp CLI flag with options: "off", "self", "inline" (default) - Configure CSP headers in HTTP server based on setting - Allow disabling CSP or using strict "self" policy - Default "inline" setting maintains backward compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be a flag. It must go in config. Also config comment should mention the issues/dangers of enabling this.
cc @patrickwoodhead re Spark FilCDN |
Hey folks! Anything I can help to move this along? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with doc changes to make it less alarmist
I like the changes from Rod. Can we run Please ensure to check the output of |
Co-authored-by: Rod Vagg <[email protected]>
I've accepted @rvagg changes but struggling now to run Any chances the codegen can be run in CI? Are there containers I can use instead? |
OpenCL should not cause issue with FFI as it is supported. Try below:
Make gen cannot be fixed in CI. |
Great! I think that did it! Thanks @LexLuthr. Just pushed the generated files. `make gen` logs
|
Nice, CI seems to be happy! 💃 |
Changes
--csp
CLI flagClaude Code Prompt