-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[docs] Performance: update outdated info #4591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The state of the Performance document is pretty outdated; this PR takes a step toward at least fixing or removing sections that would be misleading or confusing to React Native developers on the latest versions.
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Removes part about navigation transitions - Removes reference to ListView
Made those changes @satya164 ! Thank you for the review/suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit on a section being removed, otherwise looks great!
|
||
This is especially true when you have text with a transparent background positioned on top of an image, or any other situation where alpha compositing would be required to re-draw the view on each frame. You will find that enabling `shouldRasterizeIOS` or `renderToHardwareTextureAndroid` can help with this significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for renderToHardwareTextureAndroid
is still false, I would keep this section in as it's particularly relevant when reaching for overlays like drop shadows or other render effects
The state of the Performance document is pretty outdated; this PR takes a step toward at least fixing or removing sections that would be misleading or confusing to React Native developers on the latest versions.
Changes
Navigator
/NavigatorIOS
references to React NavigationshouldRasterizeIOS
andrenderToHardwareTextureAndroid
, as these are now enabled by defaultSlow navigator transitions
section, which is about the removedNavigator
animations.Minor tweaks