Fix ESLint Test #1890
Open
Fix ESLint Test #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdkopen
commented
May 1, 2025
| @@ -3,7 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "private": true, | |||
| "scripts": { | |||
| "test": "eslint --ignore-path .gitignore --ignore-pattern _includes/readmes/ \"**/*.md\"" | |||
| "test": "eslint . --ignore-path .gitignore --ignore-pattern _includes/readmes/ \"**/*.md\"" | |||
There was a problem hiding this comment.
.md files are currently part of the --ignore-pattern. Should this exclusion be removed from the test script?
When the ignore-pattern is removed there are another 261 errors that could be fixed. Right now the test doesn't enforce the .md lint rules.
bdkopen
commented
May 1, 2025
| @@ -3,7 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "private": true, | |||
| "scripts": { | |||
| "test": "eslint --ignore-path .gitignore --ignore-pattern _includes/readmes/ \"**/*.md\"" | |||
| "test": "eslint . --ignore-path .gitignore --ignore-pattern _includes/readmes/ \"**/*.md\"" | |||
There was a problem hiding this comment.
Without the ., ESLint doesn't actually run on any files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testscript whereeslintwasn't running over any files.browserandjqueryas environments so their variables are seen as defined.