Handle invalid token #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the token is invalid and the user cannot be authorized then swallong the unauthorized exception will lead to a null reference error. By exposing the HttpRequestException the application will know that the user was unauthorized. Fixes: CMS-40534
|
Great job @DeepRed! Your CI passed, and the PR has been automatically labelled. Once ready, we will merge this PR to trigger the next part of the automation 🚀 |
ManhOptimizely
approved these changes
Mar 17, 2025
|
Merged to develop. |
|
@ManhOptimizely its not urgent, just an error I found while helping on a support case. But we need a second approved to merge this. I added Ted, anyone else I should add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the token is invalid and the user cannot be authorized then swallong the unauthorized exception will lead to a null reference error. By exposing the HttpRequestException the application will know that the user was unauthorized.
Fixes: CMS-40534