A bunch of changes concerning a proper FreeFEM install #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For FreeFEM I guess having does not work ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically we don't do reviews here, but this is a special case...
There are two things worth noting. I needed to create a variation of both petsc and slepc (petsc-complex, slepc-complex) to be able to do have one install for real and one for complex scalars.
FreeFEM (in the way the user needs it) has to have support for both and I found no other way to make this work.
Most of the other recipes (e.g. mumps) should have only minor updates for newer versions.
The FreeFEM recipe is basically "new." Comments and improvements are welcome.
Do you see any other way of doing this?
I'll wait until we finalize this discussion before submitting a PR on the stack side