Skip to content

Issue #2414: Fixed mapping resolution for @Embeddable in ObjectExpression #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

Tomas-Kraus
Copy link
Member

@Tomas-Kraus Tomas-Kraus commented May 29, 2025

Attmepts to resolve mapping using before last item in derivedExpressions, which should contain proper descriptor of @Embeddable class.

descriptor.isAggregateDescriptor() check was deleted in ReportQuery#prepareSubSelect(AbstractSession, AbstractRecord, Map<Expression, Expression>) but I'm not sure whether it's OK to turn it off completely.
Anyway, the exception says "Aggregate object cannot be deleted or written", but this is sub SELECT preparation code, not DML.

@Tomas-Kraus
Copy link
Member Author

Fixes #2414.

@Tomas-Kraus Tomas-Kraus marked this pull request as ready for review May 30, 2025 15:33
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit eedffed into eclipse-ee4j:master Jun 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants