Skip to content

Feat: media3 & android auto #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

Feat: media3 & android auto #2403

wants to merge 41 commits into from
+27,433 −22,788

Conversation

puckey
Copy link
Collaborator

@puckey puckey commented Nov 18, 2024 •
edited
Loading

A work in progress pull request building on subset of @lovegaoshi's work at https://github.com/lovegaoshi/react-native-track-player

  • without crossfading support
  • without widget code in the example app
  • adds backwards support for Capability.JumpBackward and Capability.JumpForward notification buttons.
  • todo: notification icon customization needs to be readded
  • todo: reconsider the custom notification buttons api
  • todo: Apple Carplay possibly using a shared api with Android Auto

behenate and others added 15 commits November 4, 2024 13:41
@behenate @puckey
chore: improve bridgeless interop layer compatibility

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5878c5b
@robik @puckey
fix: broken events in bridgeless mode (React Native New Architecture)
d918b8e
@puckey
chore: update node to v22
f369f4a 
Node 22 has entered LTS as of October 2024
@puckey
example: update to react-native 0.76.1
Loading
Loading status checks…
82d635a 
example: fix
@puckey
android: inline KotlinAudio
4336358
@puckey
hooks: fix circular dependency
edcb7d3
@puckey
chore: remove deprecated functionalities
ef72936
@puckey
feat: initial media3 functionality
67220ad 
Brings in media3 & android-auto functionalities from https://github.com/lovegaoshi/react-native-track-player, leaving out widget & audio fading functionalities
@puckey
android: various
edd6e1a 
- show jump backward & forward buttons in notification
- remove compactCapabilities
- rename BaseAudioPlayer#player to BaseAudioPlayer#forwardingPlayer
@puckey
example: update
73abf8a
@puckey
android: remove forwarding player
825af41
@puckey
example: add android:adb-reverse script
59ebf7e
@puckey
example: update react-native to 0.76.2
067ca53
@puckey
android: default mediaId to audioItem.audioUrl
fbf550c
@puckey
android: rename timber tags to RNTP
61c8f1f
@lovegaoshi lovegaoshi mentioned this pull request Nov 25, 2024
Open
@lovegaoshi lovegaoshi mentioned this pull request Dec 10, 2024
Closed
@lovegaoshi lovegaoshi mentioned this pull request Jan 28, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Mar 13, 2025
@jspizziri jspizziri reopened this Mar 31, 2025
@jspizziri jspizziri removed the Stale label Mar 31, 2025
@Ken-Michalak
Copy link

@puckey I was trying to pick up where you left off, and it looks like it runs fine after pulling in changes from main.

For those icons in media3, it sounds like you need to add drawable icons with specific names, so if that's true, we'd probably just need to remove that config and update the docs. I wasn't having much luck testing that out in the example folder, but I can keep digging into that, unless you have any ideas there.
https://developer.android.com/reference/androidx/media3/session/DefaultMediaNotificationProvider#drawables

It seems like apple carplay should be in a separate pr, so these media3 updates can get merged in for now at least.

Is there anything else that still needs to be done on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspizziri jspizziri

@dcvz dcvz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@puckey @Ken-Michalak @jspizziri @behenate @robik @lovegaoshi