Skip to content

rewriting stored procedures #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 137 commits into from
Apr 30, 2025
Merged

rewriting stored procedures #2851

merged 137 commits into from
Apr 30, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 14, 2025

This PR reimplements Stored Procedures so that queries are run individually, while maintaining context through the use of a stack.

companion pr: dolthub/vitess#402

@jycor jycor requested a review from Hydrocharged February 25, 2025 22:51
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


    

@jycor jycor requested a review from Hydrocharged April 30, 2025 04:33
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 35 to 37
func (Assignment) OperationSize() int32 {
return 1
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned that you were deleting this file, but I think you forgot to lol

@jycor jycor merged commit d3b95b2 into main Apr 30, 2025
7 of 8 checks passed
@jycor jycor deleted the james/proc branch April 30, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants