-
-
Notifications
You must be signed in to change notification settings - Fork 221
rewriting stored procedures #2851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… into james/proc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… into james/proc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sql/procedures/statements.go
Outdated
func (Assignment) OperationSize() int32 { | ||
return 1 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned that you were deleting this file, but I think you forgot to lol
This PR reimplements Stored Procedures so that queries are run individually, while maintaining context through the use of a stack.
companion pr: dolthub/vitess#402