Add gzip compression to http payloads above a certain size #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judgeaxl
requested changes
Apr 20, 2023
There was a problem hiding this comment.
This was resolved in Slack a long time ago, but the problem with this is that it requires the receiving service is aware of gzip compression and by default that is not the case. Thus, arbitrarily compressing payloads to any service is almost guaranteed to fail. Better would be to use this as a utility wrapper around services that are known to support gzip compression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly modified version of the Sentry module gzip code to automatically compress payloads that are above a size threshold.