Add more results to GitHub App repository listing #1941
Conversation
…ve more results (100) per page
WalkthroughThe change updates the GitHub repository listing logic in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented pagination options in GithubAppCallbackPage to increase repository listing limit from 30 to 100, addressing immediate truncation issues in GitHub App repository registration.
- Modified
client.Apps.ListReposcall in/backend/controllers/github.goto usegithub.ListOptions{Page: 1, PerPage: 100} - Current fix is temporary and needs enhancement to handle pagination for >100 repositories
- Consider adding a warning or limit indicator when approaching 100 repository limit
- Recommend implementing proper pagination handling in future updates to support unlimited repositories
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| opt := &github.ListOptions{Page: 1, PerPage: 100} | ||
| listRepos, _, err := client.Apps.ListRepos(context.Background(), opt) |
There was a problem hiding this comment.
logic: This only retrieves the first 100 repositories. Need to implement pagination to handle orgs with >100 repos.
| opt := &github.ListOptions{Page: 1, PerPage: 100} | |
| listRepos, _, err := client.Apps.ListRepos(context.Background(), opt) | |
| opt := &github.ListOptions{Page: 1, PerPage: 100} | |
| var repos []*github.Repository | |
| for { | |
| listRepos, resp, err := client.Apps.ListRepos(context.Background(), opt) | |
| if err != nil { | |
| slog.Error("Failed to list existing repositories", | |
| "installationId", installationId64, | |
| "page", opt.Page, | |
| "error", err, | |
| ) | |
| c.String(http.StatusInternalServerError, "Failed to list existing repos: %v", err) | |
| return | |
| } | |
| repos = append(repos, listRepos.Repositories...) | |
| if resp.NextPage == 0 { | |
| break | |
| } | |
| opt.Page = resp.NextPage | |
| } |
Problem
We noticed that when 30 repositories are registered with the GitHub App, adding a 31st repository causes one of the existing ones (often the latest) to be removed.
https://diggertalk.slack.com/archives/C01DVJRK6CX/p1745923260568589
Root cause
By default, the GitHub API returns a limited number of results per request (usually 30). Since the call to
client.Apps.ListReposdid not explicitly handle pagination, we were unintentionally working with a truncated list of repositories.Quick fix
We now explicitly provide pagination options using
github.ListOptions{Page: 1, PerPage: 100}to ensure the API returns up to 100 repositories.This is a temporary fix, as the implementation should ideally retrieve all Git repositories.
Summary by CodeRabbit