Fix: Move the deleteScormFolder() method call to the deleteScorm() me… #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod. When calling the method ``` public function uploadScormArchive(UploadedFile $file, $uuid = null) ``` It calls within it the method: ``` private function saveScorm($file, $filename, $uuid = null) ``` Which calls the method: ``` private function generateScorm($file) ``` Which calls the `unzipper` method on the `scormDisk` object. The scorm path is cleared within the method body before the new content is made available. As `deleteScormData` is called further down in the `uploadScormArchive` method, all content is removed after a successful upload.
|
@devianl2 can someone do a pull? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the method
It calls within it the method:
Which calls the method:
Which calls the
unzippermethod on thescormDiskobject. The scorm path is cleared within the method body before the new content is made available.As
deleteScormDatais called further down in theuploadScormArchivemethod, all content is removed after a successful upload.