Skip to content

make cvmfs_http_proxy default to DIRECT (v4) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Apr 4, 2025

Cherry-pick #35 to the actions-cache-v4 branch.

@DrDaveD DrDaveD requested a review from wdconinc April 4, 2025 17:58
@wdconinc
Copy link
Collaborator

wdconinc commented Apr 4, 2025

Hmm, that's not really the right target branch. It is just a leftover branch from another PR #25 that wasn't deleted.

We should have created a v4.x branch, so let me do that starting with the v4.0 tag. I think then you can change the target of this merge.

@DrDaveD DrDaveD changed the base branch from actions-cache-v4 to main April 4, 2025 19:05
@DrDaveD DrDaveD changed the base branch from main to v4.x April 4, 2025 19:05
@DrDaveD
Copy link
Contributor Author

DrDaveD commented Apr 4, 2025

@wdconinc Ok, rebased

@wdconinc wdconinc merged commit c792ebd into cvmfs-contrib:v4.x Apr 4, 2025
3 checks passed
@DrDaveD DrDaveD deleted the pick35 branch April 7, 2025 14:57
@DrDaveD
Copy link
Contributor Author

DrDaveD commented Apr 7, 2025

@wdconinc Please also make a new v4.x tag.

@wdconinc
Copy link
Collaborator

wdconinc commented Apr 7, 2025

@wdconinc Please also make a new v4.x tag.

Both v4 and v5 tags have been pointing to branches with this fix for the weekend (see https://github.com/cvmfs-contrib/github-action-cvmfs/tags). Are you still noticing issues?

@DrDaveD
Copy link
Contributor Author

DrDaveD commented Apr 7, 2025

Ah, no, it's just that I was looking under "Releases" and not under "Tags". There's no 4.1 "Release" which is probably not that important but you might want to make one.

@wdconinc
Copy link
Collaborator

wdconinc commented Apr 7, 2025

Thanks. I added the v4.1 release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants