Skip to content

[.NET] More robust ndjson handling for Spec/UnitTests #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

This PR only modifies the Spec/UnitTests, not any shipped artifacts (e.g., NuGet assemblies).

⚡️ What's your motivation?

While working on #405, it was discovered that the .NET tests are not as robust as other implementations when handling ndjson files. See comment in #402 (comment).

This also improves the test runtime (on my machine) from 3.5 seconds to 2.5 seconds and avoids file lock errors when running the tests on Windows.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@obligaron obligaron force-pushed the refactor/testndjson branch from 3ecc963 to 3cedc21 Compare May 29, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant