[.NET] More robust ndjson handling for Spec/UnitTests #406
+21
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR only modifies the Spec/UnitTests, not any shipped artifacts (e.g., NuGet assemblies).
TokensGenerator.GenerateTokens
⚡️ What's your motivation?
While working on #405, it was discovered that the .NET tests are not as robust as other implementations when handling ndjson files. See comment in #402 (comment).
This also improves the test runtime (on my machine) from 3.5 seconds to 2.5 seconds and avoids file lock errors when running the tests on Windows.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.