-
-
Notifications
You must be signed in to change notification settings - Fork 56
Add formal EBNF spec #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -6,6 +6,35 @@ This document describes the grammar and production rules of Cucumber Expressions | |||
|
|||
A Cucumber Expression has the following [EBNF](https://en.wikipedia.org/wiki/Extended_Backus%E2%80%93Naur_form) grammar: | |||
|
|||
```ebnf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than adding a new EBNF grammar, can you please make modifications to the existing one? There should only be one grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it's important that our implementations are consistent with the formal grammar, so if we're going to update it with your proposed changes, we may also need to change the existing implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please make modifications to the existing one
existing grammar is context-specific and can't be called EBNF at all. Also it describes superset of Cucumber Expression
while there is no need to do it.
Old specification if left to provide insights into current implementation.
I couldn't find the time last year to do this, I reckon I won't find the time this year either. Merged, because this is strictly speaking an improvement. |
Hi @ilslv, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Description
This PR adds a formal specification for
Cucumber Expressions
language. For more context see #41