Upgrade logger with centralized lazy logger #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of usinng non-standard logger (appendToLog) with largely spread and duplicated debug level activation variables, I have upgraded the code to use a centralized logger. This logger (Log4J like) use patterns to reduce string concatenation computing for muted log levels. It also enable to factorize log levels and categories to make the code easier to read and maintain.
I alos have extanded some collapsed if conditions to increase readibility and replaces boolean comparisons with boolean operators. For example
myVariable == false
can be simplified with!myVariable
which reduce cognitive complexity a bit