Skip to content

feat: SSO support and clientcredentials based switchig for single sign on feature #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

feat: SSO support and clientcredentials based switchig for single sign on feature #1183

wants to merge 22 commits into from

Conversation

GHkrishna
Copy link
Contributor

@GHkrishna GHkrishna commented Apr 17, 2025 •
edited
Loading

What

  • Support SSO
  • Ability to switch between client based on clientAlias instead of

sairanjit and others added 17 commits March 12, 2025 16:11
@sairanjit
chore: remove yarn.lock and package-lock.json files (#1133)
e55d113 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@bhavanakarwade
fix: platform agent set up issue (#1136)
5e3b4bb 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
fix: Parameter validations (#1138)
3b91a03 
* fix: added api param validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: removed unnecessary validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix:resolved validations issue

Signed-off-by: bhavanakarwade <[email protected]>

* added comment on function for understanding

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolve orgid validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added space in response messages

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
@pallavighule
added tenant id in get org info (#1139)
1e4943f 
Signed-off-by: pallavighule <[email protected]>
@KambleSahil3
fix/added-yml-file-to-push-docker-images (#1142)
971a8d5 
* fix: removed prisma commands in build stage

Signed-off-by: [email protected] <[email protected]>

* feat: create yml file for all services

Signed-off-by: [email protected] <[email protected]>

* Updated Dockerfiles

Signed-off-by: [email protected] <[email protected]>

* Updated yml to push docker images

Signed-off-by: [email protected] <[email protected]>

* updated yml files

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
@KambleSahil3
fix/push docker image (#1154)
967291c 
* fix: used single yml file using matrix instead of multiple files

Signed-off-by: [email protected] <[email protected]>

* fix: renamed yml file to cicd.yml

Signed-off-by: [email protected] <[email protected]>

* fix: renamed yml file

Signed-off-by: [email protected] <[email protected]>

* fix: renamed yml file

Signed-off-by: [email protected] <[email protected]>

* chore: removed id-token and attestations

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
@sairanjit @tipusinghaw
chore: add aws module into monorepo (#1135)
b92e2fc 
* chore: add aws into monorepo

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: update tsconfig

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor:tsconfig.build.json file

Signed-off-by: Tipu_Singh <[email protected]>

* refactor: remove redundant .nvmrc file

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Tipu_Singh <[email protected]>
Co-authored-by: Tipu_Singh <[email protected]>
@sairanjit
chore: remove unused modules (#1163)
c001f78
@sairanjit
refactor: remove image-service from libs (#1164)
81eccb7 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@sairanjit
refactor: merge nats-interceptor and responses lib into common (#1165)
2bf9db7 
* refactor: merge nats-interceptor into common

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor: merge repsonses lib into common

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor: create common function to handle errors

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: add todo

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: remove missed image service

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: create separate function to handle common error

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: add comment for the purpose of the functions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: update function comments

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@sairanjit
refactor: create common package in libs (#1167)
6a8fdbd 
* refactor: merge nats-interceptor into common

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor: merge repsonses lib into common

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor: create common function to handle errors

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: add todo

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor: create common package in libs

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: remove missed image service

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* refactor: common service

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@bhavanakarwade
feat: Support nested attributes while creating schema (#1166)
0fa120f 
* wip: support nested attributes while creating schema

Signed-off-by: bhavanakarwade <[email protected]>

* wip: aligned issuance functionality with nested attributes structure

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: modify csv to json function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: formatting changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved sonar cloud issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: security hotspot issue

Signed-off-by: bhavanakarwade <[email protected]>

* feat: added schema builder function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: modify extract attributes function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: destructured objects

Signed-off-by: bhavanakarwade <[email protected]>

* feat: added description property

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade
refactor: schema data type validations (#1174)
d979119 
* wip: support nested attributes while creating schema

Signed-off-by: bhavanakarwade <[email protected]>

* wip: aligned issuance functionality with nested attributes structure

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: modify csv to json function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: formatting changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved sonar cloud issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: security hotspot issue

Signed-off-by: bhavanakarwade <[email protected]>

* feat: added schema builder function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: modify extract attributes function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: destructured objects

Signed-off-by: bhavanakarwade <[email protected]>

* feat: added description property

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added validations for schema type

Signed-off-by: bhavanakarwade <[email protected]>

* formatted enum file

Signed-off-by: bhavanakarwade <[email protected]>

* chore: added enum for indy schema data type

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
@pranalidhanavade
refactor: update organization API to support updation of country, sta…
710ef7e 
…te and city (#1180)

* refactor: update organization API to support updation of country, state and city

Signed-off-by: pranalidhanavade <[email protected]>

* resolved sonarlint issues

Signed-off-by: pranalidhanavade <[email protected]>

* resolved sonarlint issues

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade @GHkrishna
fix: redirection changes and send email
a9d3638 
Signed-off-by: pranalidhanavade <[email protected]>
@GHkrishna
fix: default behaviour
8de48be 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
feat: add clientAlias based client credential handling
3235a88 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna GHkrishna mentioned this pull request Apr 22, 2025
Open
2 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 22, 2025
View reviewed changes
libs/prisma-service/prisma/seed.ts
const encryptedToken = CryptoJS.AES.encrypt(JSON.stringify(clientCredential), process.env.CRYPTO_PRIVATE_KEY).toString();
const command = `${process.cwd()}/${scriptPath} ${dbUrl}`;

const { stdout, stderr } = await execPromise(command);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
Loading
.

Copilot Autofix

AI 2 months ago

To fix the issue, we will replace the use of execPromise with execFilePromise, which allows us to pass the command and its arguments separately. This approach avoids shell interpretation of the arguments, mitigating the risk of shell injection. Specifically:

  1. Extract the script path and arguments into separate variables.
  2. Use execFilePromise to execute the script, passing the script path as the command and the arguments as an array.
  3. Ensure that all inputs (e.g., scriptPath, dbUrl) are validated or sanitized before use.

The changes will be applied to both the importGeoLocationMasterData and updateClientCredential functions.

Suggested changeset 1
libs/prisma-service/prisma/seed.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/prisma-service/prisma/seed.ts b/libs/prisma-service/prisma/seed.ts
--- a/libs/prisma-service/prisma/seed.ts
+++ b/libs/prisma-service/prisma/seed.ts
@@ -403,5 +403,6 @@
 
-    const command = `${process.cwd()}/${scriptPath} ${dbUrl}`;
+    const scriptFullPath = `${process.cwd()}/${scriptPath}`;
+    const args = [dbUrl];
 
-    const { stdout, stderr } = await execPromise(command);
+    const { stdout, stderr } = await execPromise(scriptFullPath, args);
 
@@ -435,5 +436,6 @@
 
-    const command = `${process.cwd()}/${scriptPath} ${dbUrl} ${encryptedClientId} ${encryptedClientSecret}`;
+    const scriptFullPath = `${process.cwd()}/${scriptPath}`;
+    const args = [dbUrl, encryptedClientId, encryptedClientSecret];
 
-    const { stdout, stderr } = await execPromise(command);
+    const { stdout, stderr } = await execPromise(scriptFullPath, args);
 
EOF
@@ -403,5 +403,6 @@

const command = `${process.cwd()}/${scriptPath} ${dbUrl}`;
const scriptFullPath = `${process.cwd()}/${scriptPath}`;
const args = [dbUrl];

const { stdout, stderr } = await execPromise(command);
const { stdout, stderr } = await execPromise(scriptFullPath, args);

@@ -435,5 +436,6 @@

const command = `${process.cwd()}/${scriptPath} ${dbUrl} ${encryptedClientId} ${encryptedClientSecret}`;
const scriptFullPath = `${process.cwd()}/${scriptPath}`;
const args = [dbUrl, encryptedClientId, encryptedClientSecret];

const { stdout, stderr } = await execPromise(command);
const { stdout, stderr } = await execPromise(scriptFullPath, args);

Copilot is powered by AI and may make mistakes. Always verify output.
libs/prisma-service/prisma/seed.ts
async function main(): Promise<void> {
const command = `${process.cwd()}/${scriptPath} ${dbUrl} ${encryptedClientId} ${encryptedClientSecret}`;

const { stdout, stderr } = await execPromise(command);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
Loading
.

Copilot Autofix

AI 2 months ago

To fix the issue, we will replace the use of execPromise with execFilePromise, which allows us to pass the command and its arguments separately. This approach avoids shell interpretation of the command string and mitigates the risk of shell injection. Specifically:

  1. Extract the script path and arguments into separate variables.
  2. Use execFilePromise to execute the script with the arguments passed as an array.
  3. Ensure that all inputs (e.g., scriptPath, dbUrl, encryptedClientId, encryptedClientSecret) are validated or sanitized before use.

Changes will be made to the updateClientCredential function in libs/prisma-service/prisma/seed.ts.

Suggested changeset 1
libs/prisma-service/prisma/seed.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/prisma-service/prisma/seed.ts b/libs/prisma-service/prisma/seed.ts
--- a/libs/prisma-service/prisma/seed.ts
+++ b/libs/prisma-service/prisma/seed.ts
@@ -5,6 +5,6 @@
 import { CommonConstants } from '../../common/src/common.constant';
-import { exec } from 'child_process';
+import { execFile } from 'child_process';
 import * as util from 'util';
 import { encryptClientCredential } from '@credebl/common/cast.helper';
-const execPromise = util.promisify(exec);
+const execPromise = util.promisify(execFile);
 
@@ -435,5 +435,6 @@
 
-    const command = `${process.cwd()}/${scriptPath} ${dbUrl} ${encryptedClientId} ${encryptedClientSecret}`;
+    const scriptFullPath = `${process.cwd()}/${scriptPath}`;
+    const args = [dbUrl, encryptedClientId, encryptedClientSecret];
 
-    const { stdout, stderr } = await execPromise(command);
+    const { stdout, stderr } = await execPromise(scriptFullPath, args);
 
EOF
@@ -5,6 +5,6 @@
import { CommonConstants } from '../../common/src/common.constant';
import { exec } from 'child_process';
import { execFile } from 'child_process';
import * as util from 'util';
import { encryptClientCredential } from '@credebl/common/cast.helper';
const execPromise = util.promisify(exec);
const execPromise = util.promisify(execFile);

@@ -435,5 +435,6 @@

const command = `${process.cwd()}/${scriptPath} ${dbUrl} ${encryptedClientId} ${encryptedClientSecret}`;
const scriptFullPath = `${process.cwd()}/${scriptPath}`;
const args = [dbUrl, encryptedClientId, encryptedClientSecret];

const { stdout, stderr } = await execPromise(command);
const { stdout, stderr } = await execPromise(scriptFullPath, args);

Copilot is powered by AI and may make mistakes. Always verify output.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This was linked to issues Apr 23, 2025
feat: map client credentials from clientAlias for user email verification #1173
Open
feat: Add Single Sign On(SSO) support #1192
Open
@GHkrishna GHkrishna changed the title feat: clientcredentials based switchig for single sign on feature feat: SSO support and clientcredentials based switchig for single sign on feature Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add Single Sign On(SSO) support feat: map client credentials from clientAlias for user email verification
6 participants
@GHkrishna @sairanjit @bhavanakarwade @pallavighule @KambleSahil3 @pranalidhanavade