feat(contact): Adds GitLab for sidebar. Only display contacts that are configured. #2368
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig.yml. For GitHub, GitLab, and Twitter, they will be displayed, regardless of a username being set or not. Updates the conditional for capture/assign of `url` so that it is `nil` if no username was provided. Then when the check for `url` is done for building the link, it will be skipped if no username is configured.
|
This started as just a simple add of GitLab. Then I realized certain contacts (e.g. Twitter) were being added even when none was configured. This pull request also includes an adjustment to the conditional so that if a username is not set for GitHub or Twitter (also GitLab), then it will not be displayed in the sidebar. |
JasonRaveling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds GitLab as an option, similar to GitHub. It is an optional config. When set, it will show the GitLab icon in the sidebar with a link to the GitLab page of the configured username.