Migrate from NAN -> NAPI #281
Draft
+3,438
−3,478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cowboyd, thanks for the PR! |
|
@milindl Thanks! I'm sure that it's broken in a number of ways, but my goal was to get most of the grunt work out of the way. I'd be happy to help you all push further with this as I think it would be killer to get this working on Deno and Bun. Let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
N-API is a forward ABI compatible API that is supported by Node, Deno, and Bun. By using N-API instead of NAN,
@confluent/kafka-javascriptwill be able to run on all those runtimes as well as any other runtime that comes along that supports N-API.Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups