Skip to content

Increase stability of integration tests #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Increase stability of integration tests #22

merged 2 commits into from
Apr 10, 2025

Conversation

href
Copy link
Contributor

@href href commented Apr 9, 2025

Tests have not been stable as of late. With this change we eliminate a race condition, and we add more time to a test that sometime takes longer than expected.

The additional time may be lowered again in the future: For now we are able to show the time it takes, instead of just giving up early.

@href href force-pushed the denis/stable-tests branch 2 times, most recently from a4b89e7 to f1c0b0d Compare April 9, 2025 12:19
This is not the time we want to end up at, but with this change we
can gather metrics on this particular test, that keeps taking longer
than anticipated.

Further, we no longer continue with the test if the peeraddr deployment
was not successful.
@href href force-pushed the denis/stable-tests branch from f1c0b0d to 2d5b5ce Compare April 9, 2025 12:20
There was a race that would sometimes return a service, before it had
received its load balancer addresses, causing some tests to fail
rarely and randomly.
@href href changed the title Increase stability of TestServiceTrafficPolicyLocal Increase stability of integration tests Apr 10, 2025
@href href merged commit 61c6837 into main Apr 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant