Skip to content

Python: bazel: Compute snapshot_integrity from snapshot_hash #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 7, 2025

No description provided.

@hoodmane hoodmane requested review from a team as code owners June 7, 2025 00:41
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking on this, but could we do it the other way around? It's much easier to get a sha256 hash in CLI than this integrity thing.

@hoodmane
Copy link
Contributor Author

It requires rearranging the workspace file, but I agree it's the better way to go.

@hoodmane hoodmane changed the title Python: bazel: Compute snapshot_hash from snapshot_integrity Python: bazel: Compute snapshot_integrity from snapshot_hash Jun 10, 2025
@hoodmane hoodmane force-pushed the hoodmane/compute-baseline-snapshot-hash branch from ce00947 to 2689f24 Compare June 10, 2025 21:43
@hoodmane
Copy link
Contributor Author

Okay I fixed it to go the other way.

Copy link

github-actions bot commented Jun 10, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@hoodmane hoodmane force-pushed the hoodmane/compute-baseline-snapshot-hash branch 4 times, most recently from 5bde834 to eaff4d8 Compare June 11, 2025 19:53
@hoodmane hoodmane force-pushed the hoodmane/compute-baseline-snapshot-hash branch from eaff4d8 to e4cf064 Compare June 12, 2025 21:54

This comment was marked as resolved.

@hoodmane hoodmane merged commit c69a82c into main Jun 12, 2025
20 checks passed
@hoodmane hoodmane deleted the hoodmane/compute-baseline-snapshot-hash branch June 12, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants