-
Notifications
You must be signed in to change notification settings - Fork 394
Move vendor dir in Python search path just before site-packages. #4204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7cb6a01
to
fca27a6
Compare
/windsurf-review |
/windsurf review |
97c8ece
to
29025cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
5d5de58
to
ec91689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@hoodmane Hmm, looks like |
ec91689
to
091a6e7
Compare
We have two functions that adjust the sys path in Python Workers. The first one (adjustSysPath) only runs when not restoring from a snapshot, so it is effectively immortalised in the memory snapshots. To avoid needing to regenerate all the memory snapshots (which for package snapshots would be a problem) we just rearrange the path at the same time as when we add the vendor path to the sys path.
Test Plan