Skip to content

fix(scripts): add in checks for unknown types #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented May 14, 2025

  • support better checks for unknown figma variable types
  • update and fix handling for verbose output
  • add documentation details for how to handle import files

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

- support better checks for unknown figma variable types
- update and fix handling for verbose output
- add documentation details for how to handle import files
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (d158fa0) to head (f39056b).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2186   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         101      101           
  Lines        2403     2403           
  Branches      723      720    -3     
=======================================
  Hits         2314     2314           
  Misses         85       85           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size
components 87.51 KB (0%)
styles 24.83 KB (0%)

@booc0mtaco booc0mtaco requested a review from a team May 14, 2025 21:10
Copy link
Contributor

@ajmoreno ajmoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@booc0mtaco booc0mtaco merged commit 0ce0c28 into next May 16, 2025
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1601 branch May 16, 2025 17:31
@booc0mtaco booc0mtaco mentioned this pull request May 26, 2025
booc0mtaco added a commit that referenced this pull request May 27, 2025
…se-v16.0.1

### [16.0.1](v16.0.0...v16.0.1) (2025-05-26)

[Storybook](https://61313967cde49b003ae2a860-gszqxitnlb.chromatic.com/)

### Bug Fixes

* **Button:** update minimum width for medium button ([#2188](#2188)) ([86395a2](86395a2))
* **scripts:** add in checks for unknown types ([#2186](#2186)) ([0ce0c28](0ce0c28))
* **scripts:** address handling of color types ([#2190](#2190)) ([b81e0dc](b81e0dc))
* **tailwind:** adjust config creation to avoid TypeScript issues ([#2189](#2189)) ([14f4225](14f4225))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants