-
Notifications
You must be signed in to change notification settings - Fork 2
Add Author objects #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Author objects #103
Conversation
Author objects - draft #102
Validation Passes. |
Before we merge this, we need a strategy for compatibility with CAP author fields. |
Validation Passes. |
TBD - do we still need a separate string field for author? |
Discussed in DOS group call. Still not clear how to proceed if we want bidirectional conversion with CAP. @evanbiederstedt - please comment. |
Reopening based on discussion with @evanbiederstedt |
Validation Passes. |
- Removed author fields from primary properties. - Author_list now takes a list of objects with first author first in list - minor tweaks to author object property field names and text
Validation Passes. |
Also reverted author object requirements in CAP as Evan doesn't think we can enforce for all authors. Requirement for email and orcid for first author will move to CAP business logic
Validation Passes. |
Hi @JABelfiore & @ubyndr - did some work on this with @evanbiederstedt - can you please review. Ta |
@@ -1266,13 +1266,13 @@ Key-value pair in the `uns` dictionary | |||
</tr> | |||
<tr> | |||
<td><b>example</b></td> | |||
<td><code>'['John Smith', 'Cody Miller', 'Sarah Jones']'</code></td> | |||
<td><code>'[{'author_name':'John Smith', 'email':'[email protected]', 'orcid' :'ORCID:0000-0002-3843-3472'}]'</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear what to do in case of empty fields. Should we still write keys with empty values like 'email': None
or we can just skip it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should write keys with empty values @rm1113
Validation Passes. |
We need to update:
Additionally we will need a new TDT function that will harmonise existing manual taxonomy curations to this kind of data structure changes. Since we don't have any manual curations in the taxonomies yet, we are recreating TDT tables from scratch now. |
"author_name": { | ||
"description": "Primary author's name. This MUST be a string in the format `[FIRST NAME] [LAST NAME]`", | ||
"type": "string" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this has been removed, don't we need to remove it from;
"required": [
"author_name",
"annotations",
"labelsets"
],
Author objects - draft #102