Skip to content

[fix #546] add human language in workshop description #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

[fix #546] add human language in workshop description #625

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc8d63
[fix #546] add human language in workshop description
fmichonneau Oct 11, 2019
25e9820
incorporate @maxim-belkin comments
fmichonneau Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions _config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ flavor: "r"
# https://github.com/carpentries/workshop-template#creating-extra-pages
title: "Workshop Title"

# If this variable is set to something else than `""`, the language in which the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

## human_language: the language in which the workshop is taught.
# If set to anything other than "", a note about the language of the workshop is
# added to the workshop description.

# workshop will be taught will be included in the workshop description.
human_language: ""

#------------------------------------------------------------
# Generic settings (should not need to change).
Expand Down
11 changes: 11 additions & 0 deletions index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,17 @@ workshop is only open to people from a particular institution.
{% include lc/who.html %}
{% endif %}

{% comment %}
HUMAN LANGUAGE
{% endcomment %}

{% unless site.human_language == "" %}
<p id="human-language">
<strong>The course will be conducted in {{ site.human_language }}.</strong> For this course, we will expect our participants to have basic understanding of {{ site.human_language }}. We will have several helpers to assist you if you need some terms to be translated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

course -> workshop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about We will have several helpers to assist you if you need some terms to be translated. Which terms do you mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I copied this from @malvikasharan and I understood it as any word that could have been difficult to understand. How about replacing "terms" with "words"?

Copy link
Contributor

@maxim-belkin maxim-belkin Dec 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing "terms" with "words"?

it is better though it does not add clarity... I guess I don't understand the purpose of this sentence. I'd say something like this:

Helpers will be available if you need assistance with ... understanding lesson material. (???)

I'd also wrap the body of the paragraph.

</p>
{% endunless %}


{% comment %}
LOCATION

Expand Down