Skip to content

Fix: use proper transport for CheckReadWriteAccess #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek
Copy link
Contributor Author

/cc @natalieparellano

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.89%. Comparing base (7ebe5c6) to head (b736a96).
Report is 81 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #289       +/-   ##
===========================================
- Coverage   58.29%   38.89%   -19.39%     
===========================================
  Files          32       36        +4     
  Lines        3694     3294      -400     
===========================================
- Hits         2153     1281      -872     
- Misses       1184     1819      +635     
+ Partials      357      194      -163     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matejvasek
Copy link
Contributor Author

No idea why coverage is failing.

@matejvasek
Copy link
Contributor Author

/cc @jjbustamante

@jabrown85 jabrown85 merged commit 0916404 into buildpacks:main Apr 23, 2025
4 of 5 checks passed
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for help on reviewing this change.

func GetTransport(insecure bool) http.RoundTripper {
	if insecure {
		return &http.Transport{
			TLSClientConfig: &tls.Config{
				InsecureSkipVerify: true, // #nosec G402
			},
		}
	}
	return http.DefaultTransport
}

If insecure is false, it is exactly like it is today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants