feat: Add exclude_unconfirmed
and exclude_below_confirmations
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
Description
These are convenience methods on
TxBuilder
that can be used to filter out outpoints which do not meet a given confirmation threshold.Previously, I advocated a feature freeze on
TxBuilder
, but I believe we can make an exception for these helper methods, as they do not broaden theTxBuilder
interface’s error surface. Going forward, all other development should be directed to thebdk-tx
repository and crate.cc. @tnull
Changelog notice
Checklists
All Submissions:
cargo +nightly fmt
andcargo clippy
before committingNew Features: