feat!: use NetworkKind
#250
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #94.
This PR replaces
bitcoin::Network
forbitcoin::NetworkKind
where it applies.I also took the liberty of fixing up and adding comments on the files I touched.
Changelog
wallet_name_from_descriptor()
takesNetworkKind
instead ofNetwork
.FnOnce
takesNetworkKind
instead ofNetwork
.impl IntoWalletDescriptor for <T>
takesNetwork
insteadNetworkKind
.DescriptorTemplate::build()
takesNetworkKind
instead ofNetwork
.ExtendedKey::into_xprv()
takesNetworkKind
instead ofNetwork
.ExtendedKey::into_xpub()
takesNetworkKind
instead ofNetwork
.DerivableKey::into_extended_key()
examples updated to useNetworkKind
instead ofNetwork
.any_network()
renamed toany_network_kind()
.mainnet_network()
renamed tomainnet_network_kind()
.test_networks()
renamed totest_network_kind()
.merge_networks()
renamed tomerge_network_kinds()
.ValidNetworks
type alias renamed toValidNetworkKinds
.GeneratedKey::new()
takesValidNetworkKinds
instead ofValidNetworks
.DescriptorKey::from_public()
takesValidNetworkKinds
instead ofValidNetworks
.DescriptorKey::from_secret()
takesValidNetworkKinds
instead ofValidNetworks
.KeyError::InvalidNetwork
renamed toKeyError::InvalidNetworkKind
.DescriptorKey::override_valid_networks()
renamed tooverride_valid_network_kinds()
.NetworkKind
instead ofNetwork
.NetworkKind::Test
instead ofNetwork::{Regtest, Signet, Testnet, Testnet4}
.NetworkKind
instead ofNetwork
.Checklists
All Submissions:
cargo +nightly fmt
andcargo clippy
before committingNew Features:
Bugfixes: