Disallow output bases under GC-able directories #26138
Open
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had user's report spurious build failures due to the disk cache GC collecting files under the output base when output base and disk cache were set up at the same path.
github-actions
bot
added
team-Remote-Exec
|
We might need something more elaborate here as repo contents and disk cache probably also shouldn't share a directory. Maybe BlazeModules should report their managed directories? |
tjgq
requested changes
May 26, 2025
There was a problem hiding this comment.
The error messages don't match the condition we're testing for.
To be clear: a cache inside the output base should be ok (though perhaps ill-advised), only the output base inside a cache is a problem?
Separately - should we canonicalize paths so that the check isn't defeated by a symlink?
|
Canonicalizing paths requires more care as symlinks may not exist, will mark as ready for review again when that is fixed. |
fmeum
force-pushed
the
managed-directories
branch
from
58d31c5 to
5a8197e
Compare
|
CI is green now. I also added comments on why intermediate symlinks don't need to be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had user's report spurious build failures due to the disk cache GC collecting files under the output base when output base and disk cache were set up at the same path.