Fix and verify Java version compatibility of Java tools #26126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
Prebuilt Java tools meant to run on the user-specified `--java_{tool_,}runtime_version` must only use Java 8 language features and APIs. Previously, these tools were compiled with `--java_language_version=8`, but had access to a JDK 21 as the bootclasspath. In fact, `junitrunner` used `Stream#dropWhile`, which isn't available in a JDK 8.
Similarly, Java tools meant to run on the Java runtime provided by a Java (compilation) toolchain must only use Java 11 language features and APIs. This was the case, but they were in fact build with `--java_language_version=8` and a JDK 21, just like the other tools, thus lacking validation for this property.
This PR splits tools into two groups and enforces consistent Java language and bootclasspath runtime for them via `--@rules_java//toolchains:incompatible_language_version_bootclasspath`. Constants in `//src:release_archive.bzl` can be used to set the two minimum versions globally.
fmeum
commented
May 22, 2025
| @@ -11,7 +10,7 @@ package( | |||
|
|
|||
| licenses(["notice"]) # Apache 2.0 | |||
|
|
|||
| java_binary( | |||
| minimum_java_runtime_java_binary( | |||
There was a problem hiding this comment.
If it's sometimes necessary to build this for a higher bytecode version, we could keep it a regular java_binary and wrap it in a transitioning filegroup.
fmeum
commented
May 22, 2025
github-actions
bot
added
team-Rules-Java
fmeum
changed the title
fmeum
changed the title
fmeum
changed the title
fmeum
changed the title
|
CI is green after I fixed the bootstrap tests. |
hvadehra
reviewed
May 23, 2025
hvadehra
approved these changes
May 26, 2025
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompiled Java tools meant to run with the user-specified
--java_{tool_,}runtime_versionmust only use Java 8 language features and APIs. Previously, these tools were compiled with--java_language_version=8, but had access to a JDK 21 as the bootclasspath. In fact,junitrunnerusedStream#dropWhile, which isn't available in a JDK 8. Similarly, Java tools meant to run on the Java runtime provided by a Java (compilation) toolchain must only use Java 11 language features and APIs. This was the case, but they were in fact build with--java_language_version=8and a JDK 21, just like the other tools.This PR splits tools into two groups and enforces consistent Java language and bootclasspath runtime versions for them via
--@rules_java//toolchains:incompatible_language_version_bootclasspath. Constants in//src:release_archive.bzlcan be used to set the two minimum versions globally.Related to #26100