Add a missing null check on SkyframeLookupResult#getOrThrow
#26101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speculative fix for bazelbuild#22066
|
@rickeylev Could you test this? I failed to reproduce it. |
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-ExternalDeps
|
Yeah, reproducing it was oddly tricky. Try this: https://github.com/rickeylev/rules_python/tree/repro.bazel.22066 I built bazel with this PR and run -- looks to have worked. The NPE stack trace is gone. |
iancha1992
added
team-Rules-API
|
Also checked the sub-case where the fail() call in starlark wasn't being reported back at all -- that is also fixed |
|
@bazel-io fork 8.3.0 |
aranguyen
approved these changes
May 28, 2025
aranguyen
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 30, 2025
Speculative fix for bazelbuild#22066 Closes bazelbuild#26101. PiperOrigin-RevId: 765255882 Change-Id: I7569c3b2175d3bca527673f8aa13d1649c86942a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for #22066